Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ActionLink does not display icon when a URL is passed #2315

Closed
Pytal opened this issue Oct 15, 2021 · 4 comments · Fixed by #5053
Closed

ActionLink does not display icon when a URL is passed #2315

Pytal opened this issue Oct 15, 2021 · 4 comments · Fixed by #5053
Labels
1. to develop Accepted and waiting to be taken care of bug Something isn't working

Comments

@Pytal
Copy link
Contributor

Pytal commented Oct 15, 2021 •
edited

When a URL is passed into the icon prop on ActionLink no icon is displayed. This should work correctly like when passing a CSS class.

This only occurs with a single action, and otherwise works correctly when there are multiple actions or a dropdown menu is forced :force-menu="true"
@Pytal Pytal added bug Something isn't working 1. to develop Accepted and waiting to be taken care of labels Oct 15, 2021
@Pytal Pytal added this to the 5.0.0 milestone Oct 15, 2021
@raimund-schluessler raimund-schluessler modified the milestones: 5.0.0, 5.0.1 Feb 11, 2022
@juliushaertl
Copy link
Contributor

Could be that this is already fixed with #2532 can you check that maybe?

@Pytal
Copy link
Contributor Author

Pytal commented Mar 10, 2022

Will test this when 5.1.1 is released

@Pytal
Copy link
Contributor Author

Pytal commented Mar 23, 2022

@juliushaertl I can confirm that the icon is still blank when passing a URL as the icon prop

@raimund-schluessler raimund-schluessler modified the milestones: 5.3.1, 5.3.2 Apr 21, 2022
@juliushaertl juliushaertl modified the milestones: 5.3.2, 6.0.0 Aug 2, 2022
@raimund-schluessler
Copy link
Contributor

We discourage using icon-classes now. How do we go about URL being passed? @skjnldsv?

@juliushaertl juliushaertl modified the milestones: 6.0.0, 7.0.0 Sep 1, 2022
@jotoeri jotoeri modified the milestones: 7.0.0, 7.0.1 Oct 12, 2022
@nickvergessen nickvergessen modified the milestones: 7.0.1, 7.0.2 Oct 25, 2022
@skjnldsv skjnldsv modified the milestones: 7.0.2, 7.1.1 Nov 16, 2022
@skjnldsv skjnldsv modified the milestones: 7.1.1, 7.2.0 Dec 6, 2022
@skjnldsv skjnldsv modified the milestones: 7.2.0, 7.2.1 Dec 16, 2022
@skjnldsv skjnldsv modified the milestones: 7.3.1, 7.4.1 Jan 11, 2023
@Pytal Pytal modified the milestones: 7.4.1, 7.6.0 Jan 20, 2023
@szaimen szaimen removed this from the 7.6.0 milestone Feb 15, 2023
@szaimen szaimen added this to the 7.7.0 milestone Feb 15, 2023
@mejo- mejo- modified the milestones: 7.7.0, 7.8.0 Feb 22, 2023
@raimund-schluessler raimund-schluessler removed this from the 7.8.0 milestone Feb 27, 2023
@susnux susnux mentioned this issue Jan 10, 2024
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
1. to develop Accepted and waiting to be taken care of bug Something isn't working
Projects
None yet
Milestone
No milestone
8 participants
@nickvergessen @raimund-schluessler @juliushaertl @mejo- @skjnldsv @Pytal @szaimen @jotoeri