馃悰 (#2529): fix missing firstAction #2532
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fix reactivity of children slots
juliushaertl
approved these changes
Mar 3, 2022
There was a problem hiding this comment.
Great, much nicer than the template wrapping workaround from yesterday 馃憤
Can also be tested by comparing https://nextcloud-vue-components.netlify.app/#/Components/Modal with https://deploy-preview-2532--nextcloud-vue-components.netlify.app/#/Components/Modal
|
@vinicius73 Could you check https://github.com/nextcloud/nextcloud-vue/pull/2532/checks?check_run_id=5398774806 on how address the missing DCO Signed-off-by message? |
max-nextcloud
approved these changes
Mar 3, 2022
skjnldsv
added
3. to review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #2529