Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow listitem components to have external links #3039

Closed
tcitworld opened this issue Aug 15, 2022 · 0 comments · Fixed by #3040
Closed

Allow listitem components to have external links #3039

tcitworld opened this issue Aug 15, 2022 · 0 comments · Fixed by #3040
Labels
1. to develop Accepted and waiting to be taken care of component Component discussion and/or suggestion feature: list-item-icon Related to the list-item-icon component

Comments

@tcitworld
Copy link
Contributor

It can already be a router-link and there's already a <a> tag with href="#" being used.

We can just allow a new href prop and use it for the existing link.
@tcitworld tcitworld added 1. to develop Accepted and waiting to be taken care of component Component discussion and/or suggestion feature: list-item-icon Related to the list-item-icon component labels Aug 15, 2022
@tcitworld tcitworld mentioned this issue Aug 15, 2022
Merged
tcitworld added a commit that referenced this issue Aug 15, 2022
@tcitworld
Allow ListItem components to link to external links
e9b4dc2 
Closes #3039

Signed-off-by: Thomas Citharel <tcit@tcit.fr>
@tcitworld tcitworld mentioned this issue Aug 15, 2022
Merged
tcitworld added a commit that referenced this issue Aug 18, 2022
@tcitworld
Allow ListItem components to link to external links
5d4d7b6 
Closes #3039

Signed-off-by: Thomas Citharel <tcit@tcit.fr>
tcitworld added a commit that referenced this issue Aug 18, 2022
@tcitworld
Allow ListItem components to link to external links
5ba557d 
Closes #3039

Signed-off-by: Thomas Citharel <tcit@tcit.fr>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
1. to develop Accepted and waiting to be taken care of component Component discussion and/or suggestion feature: list-item-icon Related to the list-item-icon component
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Allow ListItem components to link to external links nextcloud-libraries/nextcloud-vue
1 participant
@tcitworld