Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[7.0.1] "too much recursion" when opening NcModal and NcAppSettingsDialog #3386

Closed
dartcafe opened this issue Oct 21, 2022 · 4 comments · Fixed by #3478
Closed

[7.0.1] "too much recursion" when opening NcModal and NcAppSettingsDialog #3386

dartcafe opened this issue Oct 21, 2022 · 4 comments · Fixed by #3478
Assignees
@vinicius73
Labels
1. to develop Accepted and waiting to be taken care of bug Something isn't working feature: modal Related to the modal component high High priority regression Regression of a previous working feature
Milestone
7.1.0

Comments

@dartcafe
Copy link
Contributor

When opening NcModal, it opens slowly and the following errors are thrown in the JS console:

Test it with https://nextcloud-vue-components.netlify.app/#/Components/NcModal

grafik
@dartcafe dartcafe added bug Something isn't working feature: modal Related to the modal component regression Regression of a previous working feature labels Oct 21, 2022
@ChristophWurst
Copy link
Contributor

Can confirm when I link master against Mail and open a settings modal

Bildschirmfoto vom 2022-10-21 15-53-30

👀 @vinicius73

pulsejet added a commit to pulsejet/memories that referenced this issue Oct 21, 2022
@pulsejet
Pin @nextcloud/vue to 7.0.0
5a68e3b 
Blocked by nextcloud-libraries/nextcloud-vue#3386
@ChristophWurst
Copy link
Contributor

Tracked in nextcloud/nextcloud-focus-trap#2

@ChristophWurst ChristophWurst added the 1. to develop Accepted and waiting to be taken care of label Oct 24, 2022
@ChristophWurst ChristophWurst mentioned this issue Oct 24, 2022
Closed
@nickvergessen nickvergessen added the high High priority label Oct 25, 2022
@nickvergessen nickvergessen modified the milestones: 7.0.1, 7.0.2 Oct 25, 2022
@ChristophWurst ChristophWurst mentioned this issue Oct 28, 2022
Closed
@MarcelRobitaille MarcelRobitaille mentioned this issue Nov 1, 2022
Merged
@PVince81
Copy link
Contributor

PVince81 commented Nov 4, 2022

waiting for focus-trap/focus-trap#826

@SystemKeeper SystemKeeper mentioned this issue Nov 9, 2022
Closed
9 tasks
@skjnldsv skjnldsv mentioned this issue Nov 15, 2022
Merged
@dartcafe
Copy link
Contributor Author

🎉

@skjnldsv skjnldsv modified the milestones: 7.0.2, 7.1.0 Nov 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@vinicius73 vinicius73

Labels
1. to develop Accepted and waiting to be taken care of bug Something isn't working feature: modal Related to the modal component high High priority regression Regression of a previous working feature
Projects
None yet
Milestone
7.1.0
Development

Successfully merging a pull request may close this issue.

Define global focus trap nextcloud-libraries/nextcloud-vue
6 participants
@nickvergessen @PVince81 @ChristophWurst @vinicius73 @skjnldsv @dartcafe