Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Link/mention picker should not pop up when typing inside a word #5351

Closed
nickvergessen opened this issue Mar 6, 2024 · 2 comments · Fixed by #5378
Closed

Link/mention picker should not pop up when typing inside a word #5351

nickvergessen opened this issue Mar 6, 2024 · 2 comments · Fixed by #5378
Labels
1. to develop Accepted and waiting to be taken care of bug Something isn't working feature: rich-contenteditable Related to the rich-contenteditable components

Comments

@nickvergessen
Copy link
Contributor

nickvergessen commented Mar 6, 2024

Try to post something like:

Works now in direction A/B

The / brings up the link picker:
grafik

Pressing ESC not only closes the link picker but also unfocuses the chat input of Talk.

Same happens with @ inside words.

From my perspective it would be the best to only start the picker with a leading whitespace, linebreak, empty (beginning of message). Showing it in the middle of a word is quite annoying.

Should also take a look into the ESC handling so when it cancels Tribute, it does not additionally cancel the NcContentEditable focus. moved to other issue and solved

cc @ShGKme @Antreesy

@nickvergessen nickvergessen added bug Something isn't working 1. to develop Accepted and waiting to be taken care of feature: rich-contenteditable Related to the rich-contenteditable components labels Mar 6, 2024
@Antreesy
Copy link
Contributor

Antreesy commented Mar 6, 2024

From what I see in the library code, there's no way to use regex for this as trigger for mentions. Manual trigger with /(?:^|\s)@$/ instead of @ doesn't seem to behave properly
One more reason to fork the lib

@Antreesy
Copy link
Contributor

Antreesy commented Mar 8, 2024

Regression comes with 0bf2293

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1. to develop Accepted and waiting to be taken care of bug Something isn't working feature: rich-contenteditable Related to the rich-contenteditable components
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants