Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(NcRichContentEditable): require leading space to open tributes #5378

Merged
merged 1 commit into from
Mar 8, 2024

Conversation

Antreesy
Copy link
Contributor

@Antreesy Antreesy commented Mar 8, 2024

☑️ Resolves

🖼️ Screenshots

🏚️ Before 🏡 After
B A
Screenshot from 2024-03-08 10-37-54 Screenshot from 2024-03-08 10-39-17

🏁 Checklist

  • ⛑️ Tests are included or are not applicable
  • 3️⃣ Backport to next requested with a Vue 3 upgrade

Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>
@Antreesy Antreesy added bug Something isn't working 3. to review Waiting for reviews feature: rich-contenteditable Related to the rich-contenteditable components labels Mar 8, 2024
@Antreesy Antreesy added this to the 8.10.0 milestone Mar 8, 2024
@Antreesy Antreesy self-assigned this Mar 8, 2024
@susnux susnux merged commit 7dad4d6 into master Mar 8, 2024
18 checks passed
@susnux susnux deleted the fix/5351/leading-space-tribute branch March 8, 2024 09:47
@Antreesy
Copy link
Contributor Author

Antreesy commented Mar 8, 2024

/backport to next

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews bug Something isn't working feature: rich-contenteditable Related to the rich-contenteditable components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Link/mention picker should not pop up when typing inside a word
3 participants