Quickfix for action button and material design icon #1614
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Nov 27, 2020
PVince81
force-pushed
the
bugfix/noid/actionbutton-align-materialdesignicon
branch
from
07896a5
to
0ddf83c
Compare
PVince81
requested review from
juliushaertl,
marcoambrosini,
violoncelloCH and
ChristophWurst
PVince81
added
3. to review
|
Without the CSS fix: With the CSS fix: |
ChristophWurst
approved these changes
Nov 30, 2020
|
@ma12-co seems 16 is too small here I used 16 for the material design icons: hmmm, but 24 is maybe too big indeed: here's 20: let's go with 20 then ? this is anyway just a code example... ideally in the future we should have a way to only provide the icon name... |
|
@PVince81 I agree that 18 or 20 would look better, but for now 16px is our default in Nextcloud. We can talk about bumping that up a bit but I wouldn't do it here. |
ok, fine. adjusted. please review |
When using a material design icon in the icon slot, this fix will properly align it vertically. Signed-off-by: Vincent Petry <vincent@nextcloud.com>
Since 16px is an existing default, let's use that in the recommendation for when using material design icons in the ActionButton. Signed-off-by: Vincent Petry <vincent@nextcloud.com>
PVince81
force-pushed
the
bugfix/noid/actionbutton-align-materialdesignicon
branch
from
2178912
to
3446414
Compare
|
rebased for cypress fix |
ChristophWurst
approved these changes
Dec 1, 2020
juliushaertl
approved these changes
Dec 1, 2020
PVince81
deleted the
bugfix/noid/actionbutton-align-materialdesignicon
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using a material design icon in the icon slot, this fix will
properly align it vertically.
We need it because the ActionButton consumer cannot override the styles with
::v-deepsince the popover itself might be in the document bodyWhen testing the docs you might need to scroll up or down to see the dropdown because of nextcloud/server#23872 which also occurs in the docs...