-
Notifications
You must be signed in to change notification settings - Fork 81
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Modal component init #212
Modal component init #212
Conversation
What's that?
Yes. |
Small animation with a fadein+zoomin on show and the reverse on out :) |
Do it! |
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
@ChristophWurst @juliushaertl thoughts? :) |
Regarding the animation, the question is what the context is:
|
I have absolutely no idea if I can do that 🤔 👍 for the rest! ;) |
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
71a8cb4
to
5a57080
Compare
Done!
(Ignore the arrow staying, this is a quick vue example I did :p ) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good stuff design-wise! 👍
I doubt that the effort for such a implementation is worth it as the animation should be smooth and fast so a quick fade in + zoom is fine imo. |
Closes #210
Okay, so I did not wanted to implement anything more because I felt that it was the app's problem to handle this:
Details:
Questions / issues:
Should we rely on the modal component for the show/hide zoom animation? We could do that with the beforeMount/beforeDestroy stuff as well :)the app-content have a z-index of 1000 so it means that the modal cannot be above the header (because zindex gets blocked by any lower parent) We need to fix it (yeaaah, let's touch zindexes again!! :O )SOLUTION: you cannot have the modal inside the
#app-content
elementSOLUTION: use v-if and not v-show for the modal