-
Notifications
You must be signed in to change notification settings - Fork 81
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use NcSelect
for NcActionInput
type multiselect
#3760
Conversation
NcSelect
for NcActionInput
type multiselect
Does not change much on the functionality (still that z-index issues), but from the styling it now looks different. Same with the border radius, it looks rounder than the other input types, but this was even before so not related to this PR (it just catch my eye). |
I would say, the other inputs need to be adjusted. Ideally, we should use an |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎨
d40fd7e
to
d8d4001
Compare
Signed-off-by: Raimund Schlüßler <raimund.schluessler@mailbox.org>
d8d4001
to
eba673e
Compare
Signed-off-by: Joas Schilling <coding@schilljs.com>
This replaces the deprecated
NcMultiselect
with the newNcSelect
component for theNcActionInput
component of type multiselect.Although it got better (the dropdown wasn't visible at all before),Like before, there currently still is az-index
issue for the select dropdown. This is because theNcActions
component has az-index: 100000
and the select dropdown only got9999
. Fixing this is tricky at the moment, because the dropdown gets appended to body without a custom class that could be targeted, which means we can only set thez-index
for all select dropdowns globally, which I don't know whether we want this. The proper solution would be to enhanceNcSelect
to allow to set a custom dropdown class, but that needs an upstream fix.I propose we go ahead despite the z-index issue, since it is already better than before.
Fixes 1/3 of #3743.