Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

enh(NcActions): Navigation link actions #4084

Merged
merged 1 commit into from May 25, 2023
Merged

enh(NcActions): Navigation link actions #4084

merged 1 commit into from May 25, 2023

Conversation

Pytal
Copy link
Contributor

@Pytal Pytal commented May 11, 2023 •
edited

@Pytal Pytal added 3. to review Waiting for reviews feature: actions Related to the actions components accessibility Making sure we design for the widest range of people possible, including those who have disabilities labels May 11, 2023
@Pytal Pytal added this to the 8.0.0 milestone May 11, 2023
@Pytal Pytal self-assigned this May 11, 2023
@Pytal Pytal mentioned this pull request May 11, 2023
Closed
12 tasks
@Pytal
Copy link
Contributor Author

Pytal commented May 11, 2023

/backport to stable7

@Pytal Pytal requested a review from skjnldsv May 12, 2023 01:31
@skjnldsv
Copy link
Contributor

I haven't realized that would look that complex 🙈
I can approve, but I'm really unsure

@Pytal
Copy link
Contributor Author

Pytal commented May 12, 2023

I haven't realized that would look that complex 🙈 I can approve, but I'm really unsure

Either way is fine with me, just the initial reason for not detecting it automatically in the first place was that the overhead didn't seem worth it

Let me know which way you'd think is best and I'll update as needed :)

@Pytal
Copy link
Contributor Author

Pytal commented May 24, 2023

Which one do you think is best @skjnldsv?

@skjnldsv
Copy link
Contributor

Which one do you think is best @skjnldsv?

I don't know.
I feel both solutions have their own dilemmas :/

artonge
artonge approved these changes May 25, 2023
View reviewed changes
Copy link
Contributor

@artonge artonge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Auto-detecting looks ok to me.
I would add a comment, though.

@Pytal
enh(NcActions): Navigation link actions
ff5ad4b 
Signed-off-by: Christopher Ng <chrng8@gmail.com>
@Pytal Pytal added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels May 25, 2023
@Pytal Pytal merged commit e11cc33 into master May 25, 2023
16 checks passed
@Pytal Pytal deleted the enh/a11y-nav-actions branch May 25, 2023 17:40
@backportbot-nextcloud backportbot-nextcloud bot mentioned this pull request May 25, 2023
Merged
@Pytal Pytal mentioned this pull request Jun 6, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JuliaKirschenheuter JuliaKirschenheuter JuliaKirschenheuter approved these changes

@artonge artonge artonge approved these changes

@susnux susnux Awaiting requested review from susnux

@skjnldsv skjnldsv Awaiting requested review from skjnldsv

Assignees

@Pytal Pytal

Labels
4. to release Ready to be released and/or waiting for tests to finish accessibility Making sure we design for the widest range of people possible, including those who have disabilities feature: actions Related to the actions components
Projects
None yet
Milestone
8.0.0
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@Pytal @skjnldsv @JuliaKirschenheuter @artonge