Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix NcModal does set the background color but not the text color #4221

Merged
merged 1 commit into from Jun 16, 2023
Merged

Fix NcModal does set the background color but not the text color #4221

merged 1 commit into from Jun 16, 2023

Conversation

susnux
Copy link
Contributor

@susnux susnux commented Jun 15, 2023

☑️ Resolves

As it sets the background color it should also set the foreground color as it can not assume the default will match the contrast criteria.

🖼️ Screenshots

🏚️ Before 🏡 After
image image

🏁 Checklist

  • ⛑️ Tests are included or are not applicable
  • 📘 Component documentation has been extended, updated or is not applicable

@susnux
fix(NcModal): The modal does set the background color but not the tex…
77aa605 
…t color

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
@susnux susnux added bug Something isn't working design Design, UX, interface and interaction design feature: modal Related to the modal component labels Jun 15, 2023
marcoambrosini
marcoambrosini approved these changes Jun 16, 2023
View reviewed changes
Copy link
Contributor

@marcoambrosini marcoambrosini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👌

@raimund-schluessler raimund-schluessler merged commit 001ab67 into master Jun 16, 2023
16 checks passed
@raimund-schluessler raimund-schluessler deleted the fix/modal-color-not-set branch June 16, 2023 07:40
@skjnldsv skjnldsv mentioned this pull request Jun 28, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@raimund-schluessler raimund-schluessler raimund-schluessler approved these changes

@marcoambrosini marcoambrosini marcoambrosini approved these changes

@nickvergessen nickvergessen Awaiting requested review from nickvergessen

Assignees
No one assigned
Labels
bug Something isn't working design Design, UX, interface and interaction design feature: modal Related to the modal component
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Modal not dark mode compatible (on public pages)
3 participants
@susnux @raimund-schluessler @marcoambrosini