Use NcSelect in NcRichtext #4247
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Julien Veyssier <julien-nc@posteo.net>
julien-nc
added
3. to review
5 tasks
Signed-off-by: Julien Veyssier <julien-nc@posteo.net>
julien-nc
force-pushed
the
enh/3743/use-ncselect-in-ncrichtext
branch
from
42fa122
to
218f2ad
Compare
Pytal
approved these changes
Jun 22, 2023
lmk if it works with nextcloud-deps/vue-select#20 :) |
raimund-schluessler
approved these changes
Jun 23, 2023
Interesting. I'll check if it helps. |
…arch Signed-off-by: Julien Veyssier <julien-nc@posteo.net>
…issue when 'searching for more' in NcRichtext's NcSearch Signed-off-by: Julien Veyssier <julien-nc@posteo.net>
|
@Pytal Much better with vokoscreenNG-2023-06-23_11-07-41.mp4 |
|
Added another commit to make sure the option keys are unique. (It's just setting the |
Pytal
approved these changes
Jun 23, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
refs #3743
Switch to
NcSelectinNcProviderListandNcSearchfromNcRichText.I couldn't figure out a way to avoid an issue with NcSearch. When selecting a "Load more..." item, even if we actually select the item while searching for more results, the selection jumps to the top and then back to the "more" item.
Not so pretty...but not so bad.
vokoscreenNG-2023-06-22_13-27-31.mp4