NcActionLink - provide download attributes for single action button in NcAction
#4263
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Antreesy
added
bug
Antreesy
requested review from
raimund-schluessler,
szaimen,
skjnldsv and
ShGKme
Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>
Antreesy
force-pushed
the
fix/4262/fix-nc-action-link
branch
from
ff64c7f
to
3e4795f
Compare
susnux
approved these changes
Jun 26, 2023
ShGKme
approved these changes
Jun 30, 2023
|
/backport to stable7 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
☑️ Resolves
NcActionLink- different behavior in popover and as a single one #4262To reproduce:
Viewer.vuefile https://github.com/nextcloud/viewer/blob/master/src/views/Viewer.vue#L95🖼️ Screenshots
🚧 Tasks
🏁 Checklist