fix: Ensure extract-l10n extracts strings from properties
#4274
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ia-label="t()"` Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
susnux
requested review from
raimund-schluessler,
skjnldsv,
marcoambrosini and
a team
As a workaround we can use computed props there. We do that in other places already. |
skjnldsv
approved these changes
Jun 27, 2023
|
Nice! |
raimund-schluessler
approved these changes
Jun 27, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
☑️ Resolves
There are still some (two at this moment) string which can not be extracted because they are used within properties like
:aria-label="t(...)".To resolve this we need to use the HTML extractor on vue SFC files.
The huge diff is from applying our code style rules (tab vs spaces).
BTW I tried
gettext-extractor-vuewritten by the gitlab team, but that does not work as it converts allt()calls to_t()or different (compile the SFC), so the extractor does not know which strings to extract.🏁 Checklist