Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature: Add checkbox buttons (NcCheckboxRadioSwitch buttons that look like NcButtons) #4280

Closed
wants to merge 3 commits into from
Closed

Feature: Add checkbox buttons (NcCheckboxRadioSwitch buttons that look like NcButtons) #4280

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
225e2e5
feat(NcCheckboxRadioSwitch): Allow to create checkbox buttons to crea…
susnux Jun 27, 2023
f9854bf
fix(NcAppSidebar): Star button should be implemented as a checkbox fo…
susnux Jun 27, 2023
7686227
fixup! Do not allow primary and use primary for checked state only
susnux Jul 4, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
35 changes: 23 additions & 12 deletions src/components/NcAppSidebar/NcAppSidebar.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,7 @@ include a standard-header like it's used by the files app.
```vue
<template>
<NcAppSidebar
:starred="starred"
name="cat-picture.jpg"
subname="last edited 3 weeks ago">
<NcAppSidebarTab name="Search" id="search-tab">
Expand Down Expand Up @@ -65,6 +66,11 @@ include a standard-header like it's used by the files app.
Cog,
ShareVariant,
},
data() {
return {
starred: false,
}
},
}
</script>
```
Expand Down Expand Up @@ -374,17 +380,20 @@ export default {
<!-- favourite icon -->
<div v-if="canStar || $slots['tertiary-actions']" class="app-sidebar-header__tertiary-actions">
<slot name="tertiary-actions">
<NcButton v-if="canStar"
:aria-label="favoriteTranslated"
<NcCheckboxRadioSwitch v-if="canStar"
:checked="isStarred"
icon-only
class="app-sidebar-header__star"
type="secondary"
@click.prevent="toggleStarred">
type="checkbox"
button-variant="secondary"
@update:checked="toggleStarred">
<template #icon>
<NcLoadingIcon v-if="starLoading" />
<Star v-else-if="isStarred" :size="20" />
<StarOutline v-else :size="20" />
</template>
</NcButton>
{{ favoriteTranslated }}
</NcCheckboxRadioSwitch>
</slot>
</div>

Expand Down Expand Up @@ -472,13 +481,14 @@ export default {
</template>

<script>
import NcAppSidebarTabs from './NcAppSidebarTabs.vue'
import Focus from '../../directives/Focus/index.js'
import Linkify from '../../directives/Linkify/index.js'
import NcActions from '../NcActions/index.js'
import NcLoadingIcon from '../NcLoadingIcon/index.js'
import NcAppSidebarTabs from './NcAppSidebarTabs.vue'
import NcButton from '../NcButton/index.js'
import NcCheckboxRadioSwitch from '../NcCheckboxRadioSwitch/index.js'
import NcEmptyContent from '../NcEmptyContent/index.js'
import Focus from '../../directives/Focus/index.js'
import Linkify from '../../directives/Linkify/index.js'
import NcLoadingIcon from '../NcLoadingIcon/index.js'
import Tooltip from '../../directives/Tooltip/index.js'
import { t } from '../../l10n.js'

Expand All @@ -493,13 +503,14 @@ export default {
name: 'NcAppSidebar',

components: {
ArrowRight,
Close,
NcActions,
NcAppSidebarTabs,
ArrowRight,
NcButton,
NcLoadingIcon,
NcCheckboxRadioSwitch,
NcEmptyContent,
Close,
NcLoadingIcon,
Star,
StarOutline,
},
Expand Down
Loading
Loading