Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Drop install entry point and replace it with an Vue Plugin #4349

Merged
merged 1 commit into from Jul 20, 2023
Merged

chore: Drop install entry point and replace it with an Vue Plugin #4349

merged 1 commit into from Jul 20, 2023

Conversation

susnux
Copy link
Contributor

@susnux susnux commented Jul 18, 2023

☑️ Resolves

The entry point is unused and just adds another 1.2MiB of assets for the package.
Instead this will add a Vue plugin as a named export.

🧪 Tests included

🏁 Checklist

  • ⛑️ Tests are included or are not applicable
  • 📘 Component documentation has been extended, updated or is not applicable

@susnux susnux added 3. to review Waiting for reviews breaking PR that requires a new major version labels Jul 18, 2023
ShGKme
ShGKme reviewed Jul 18, 2023
View reviewed changes
Copy link
Contributor

@ShGKme ShGKme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agree with install entrypoint removing

tests/unit/plugin.spec.ts Outdated Show resolved Hide resolved
tests/unit/plugin.spec.ts Outdated Show resolved Hide resolved
@susnux susnux force-pushed the chore/drop-install-entrypoint branch from 39a3260 to c102616 Compare July 18, 2023 21:12
@susnux
chore: Drop install entry point and replace it with an Vue Plugin
a42fc29 
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
@susnux susnux force-pushed the chore/drop-install-entrypoint branch from c102616 to a42fc29 Compare July 19, 2023 20:06
@susnux susnux requested review from ShGKme and a team July 19, 2023 20:07
@juliushaertl juliushaertl merged commit f0442aa into master Jul 20, 2023
17 checks passed
@juliushaertl juliushaertl deleted the chore/drop-install-entrypoint branch July 20, 2023 10:31
@juliushaertl juliushaertl added this to the 8.0.0 milestone Jul 20, 2023
@skjnldsv skjnldsv mentioned this pull request Aug 11, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@juliushaertl juliushaertl juliushaertl approved these changes

@ShGKme ShGKme ShGKme approved these changes

@raimund-schluessler raimund-schluessler Awaiting requested review from raimund-schluessler

@skjnldsv skjnldsv Awaiting requested review from skjnldsv

Assignees
No one assigned
Labels
3. to review Waiting for reviews breaking PR that requires a new major version
Projects
None yet
Milestone
8.0.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@susnux @juliushaertl @ShGKme