Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add menuitem role to action link #4436

Merged
merged 1 commit into from Aug 23, 2023
Merged

Add menuitem role to action link #4436

merged 1 commit into from Aug 23, 2023

Conversation

Pytal
Copy link
Contributor

@Pytal Pytal commented Aug 19, 2023

☑️ Resolves

🏁 Checklist

  • ⛑️ Tests are included or are not applicable
  • 📘 Component documentation has been extended, updated or is not applicable

@Pytal
Add menuitem role to action link
381ae43 
Signed-off-by: Christopher Ng <chrng8@gmail.com>
@Pytal Pytal added 3. to review Waiting for reviews feature: actions Related to the actions components accessibility Making sure we design for the widest range of people possible, including those who have disabilities labels Aug 19, 2023
@Pytal Pytal added this to the 8.0.0 milestone Aug 19, 2023
@Pytal Pytal self-assigned this Aug 19, 2023
@Pytal Pytal mentioned this pull request Aug 19, 2023
Closed
10 tasks
@susnux susnux merged commit 9e4da30 into master Aug 23, 2023
16 checks passed
@susnux susnux deleted the enh/a11y-link-menuitem branch August 23, 2023 19:26
@skjnldsv skjnldsv added the enhancement New feature or request label Aug 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@susnux susnux susnux approved these changes

@JuliaKirschenheuter JuliaKirschenheuter JuliaKirschenheuter approved these changes

@ShGKme ShGKme ShGKme approved these changes

@Fenn-CS Fenn-CS Awaiting requested review from Fenn-CS

Assignees

@Pytal Pytal

Labels
3. to review Waiting for reviews accessibility Making sure we design for the widest range of people possible, including those who have disabilities enhancement New feature or request feature: actions Related to the actions components
Projects
None yet
Milestone
8.0.0
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@Pytal @susnux @JuliaKirschenheuter @ShGKme @skjnldsv