Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add accessible label to textarea #4448

Merged
merged 1 commit into from Aug 23, 2023
Merged

Add accessible label to textarea #4448

merged 1 commit into from Aug 23, 2023

Conversation

Pytal
Copy link
Contributor

@Pytal Pytal commented Aug 23, 2023 •
edited

Replace strong with label

The text is now not bolded which is consistent with the action input visible label

🖼️ Screenshots

🏚️ Before 🏡 After
image image

🏁 Checklist

  • ⛑️ Tests are included or are not applicable
  • 📘 Component documentation has been extended, updated or is not applicable

@Pytal
Add accessible label to textarea
283782b 
Signed-off-by: Christopher Ng <chrng8@gmail.com>
@Pytal Pytal added 3. to review Waiting for reviews accessibility Making sure we design for the widest range of people possible, including those who have disabilities labels Aug 23, 2023
@Pytal Pytal added this to the 8.0.0 milestone Aug 23, 2023
@Pytal Pytal self-assigned this Aug 23, 2023
@Pytal Pytal mentioned this pull request Aug 23, 2023
Closed
3 tasks
@raimund-schluessler raimund-schluessler merged commit daed212 into master Aug 23, 2023
16 checks passed
@raimund-schluessler raimund-schluessler deleted the enh/a11y/text-editable-label branch August 23, 2023 09:32
@skjnldsv skjnldsv added the enhancement New feature or request label Aug 24, 2023
@skjnldsv
Copy link
Contributor

Please set enhancement or bug label next time :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@raimund-schluessler raimund-schluessler raimund-schluessler approved these changes

@JuliaKirschenheuter JuliaKirschenheuter JuliaKirschenheuter approved these changes

@susnux susnux Awaiting requested review from susnux

@artonge artonge Awaiting requested review from artonge

Assignees

@Pytal Pytal

Labels
3. to review Waiting for reviews accessibility Making sure we design for the widest range of people possible, including those who have disabilities enhancement New feature or request
Projects
None yet
Milestone
8.0.0
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@Pytal @skjnldsv @raimund-schluessler @JuliaKirschenheuter