-
Notifications
You must be signed in to change notification settings - Fork 81
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(a11y): Remove nav and radios in sidebar tabs #4456
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pytal
added
3. to review
Waiting for reviews
accessibility
Making sure we design for the widest range of people possible, including those who have disabilities
labels
Aug 24, 2023
7 tasks
susnux
reviewed
Aug 24, 2023
skjnldsv
added
2. developing
Work in progress
and removed
3. to review
Waiting for reviews
labels
Aug 24, 2023
susnux
approved these changes
Aug 24, 2023
Pytal
force-pushed
the
fix/a11y/app-sidebar-tabs
branch
from
August 25, 2023 00:07
9f55855
to
587e6a4
Compare
Pytal
added
3. to review
Waiting for reviews
bug
Something isn't working
and removed
2. developing
Work in progress
labels
Aug 25, 2023
ShGKme
approved these changes
Aug 25, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works with a screen reader, but a bit buggy with both screen reading and Tab navigation sometimes, because each tab button actually is 2 focusable elements: <input type="button">
and <label>
. Though input has position absolute, it is still focusable.
Signed-off-by: Christopher Ng <chrng8@gmail.com>
Signed-off-by: Christopher Ng <chrng8@gmail.com>
Pytal
force-pushed
the
fix/a11y/app-sidebar-tabs
branch
from
August 26, 2023 00:12
587e6a4
to
5580da2
Compare
Pytal
added
4. to release
Ready to be released and/or waiting for tests to finish
and removed
3. to review
Waiting for reviews
labels
Aug 26, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
4. to release
Ready to be released and/or waiting for tests to finish
accessibility
Making sure we design for the widest range of people possible, including those who have disabilities
bug
Something isn't working
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
☑️ Resolves
🚧 Tasks
Remove redundant
nav
for element with tablist roleRemove radios in favour of input with
type="button"
Ref: https://www.w3.org/WAI/ARIA/apg/patterns/tabs/examples/tabs-automatic/#sc1_label
🏁 Checklist