Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

enh(NcAppNavigationCaption): Forward listeners #4494

Merged
merged 1 commit into from Sep 6, 2023

Conversation

Pytal
Copy link
Contributor

@Pytal Pytal commented Aug 31, 2023

Summary

Forward listeners to NcActions

馃弫 Checklist

  • 鉀戯笍 Tests are included or are not applicable
  • 馃摌 Component documentation has been extended, updated or is not applicable

@Pytal Pytal added enhancement New feature or request 3. to review Waiting for reviews feature: app-navigation Related to the app-navigation component feature: actions Related to the actions components labels Aug 31, 2023
@Pytal Pytal added this to the 8.0.0 milestone Aug 31, 2023
@Pytal Pytal self-assigned this Aug 31, 2023
Signed-off-by: Christopher Ng <chrng8@gmail.com>
@Pytal Pytal force-pushed the enh/forward-caption-listeners branch from 228f941 to 2094f57 Compare September 2, 2023 00:23
Copy link
Contributor

@ShGKme ShGKme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense as it is a wrapper around NcActions.

@Pytal Pytal requested a review from artonge September 5, 2023 17:59
@Pytal Pytal added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Sep 6, 2023
@Pytal Pytal merged commit d33b1f5 into master Sep 6, 2023
16 checks passed
@Pytal Pytal deleted the enh/forward-caption-listeners branch September 6, 2023 17:10
@Pytal Pytal mentioned this pull request Sep 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4. to release Ready to be released and/or waiting for tests to finish enhancement New feature or request feature: actions Related to the actions components feature: app-navigation Related to the app-navigation component
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants