Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(vue3): Migrate NcDatetimePickerNative #4533

Merged
merged 1 commit into from Sep 20, 2023
Merged

feat(vue3): Migrate NcDatetimePickerNative #4533

merged 1 commit into from Sep 20, 2023

Conversation

raimund-schluessler
Copy link
Contributor

This migrates NcDatetimePickerNative to vue 3.

I also renamed NcDateTimePickerNative to NcDatetimePickerNative, because it always bothered me, that we have a NcDatetimePicker and a NcDateTimePicker*.

@raimund-schluessler raimund-schluessler added the vue 3 Related to the vue 3 migration label Sep 17, 2023
@raimund-schluessler raimund-schluessler added this to the 9.0.0 next Vue 3 milestone Sep 17, 2023
@raimund-schluessler raimund-schluessler force-pushed the feat/2154/datetime-picker-native branch 3 times, most recently from 6f0fb3b to 42d2f53 Compare September 17, 2023 20:45
@raimund-schluessler raimund-schluessler marked this pull request as ready for review September 17, 2023 20:47
@raimund-schluessler raimund-schluessler added 3. to review Waiting for reviews feature: datepicker Related to the date/time picker component labels Sep 17, 2023
@raimund-schluessler
feat(vue3): Migrate NcDatetimePickerNative
5f95ed0 
Signed-off-by: Raimund Schlüßler <raimund.schluessler@mailbox.org>
JuliaKirschenheuter
JuliaKirschenheuter approved these changes Sep 20, 2023
View reviewed changes
Copy link
Contributor

@JuliaKirschenheuter JuliaKirschenheuter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

haven't tested but looks good

@raimund-schluessler raimund-schluessler merged commit c2c0207 into next Sep 20, 2023
15 checks passed
@raimund-schluessler raimund-schluessler deleted the feat/2154/datetime-picker-native branch September 20, 2023 16:40
@raimund-schluessler raimund-schluessler mentioned this pull request Sep 23, 2023
Merged
2 tasks
@susnux susnux mentioned this pull request Jan 23, 2024
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ShGKme ShGKme ShGKme approved these changes

@JuliaKirschenheuter JuliaKirschenheuter JuliaKirschenheuter approved these changes

@skjnldsv skjnldsv skjnldsv approved these changes

@susnux susnux Awaiting requested review from susnux

@Pytal Pytal Awaiting requested review from Pytal

Assignees
No one assigned
Labels
3. to review Waiting for reviews feature: datepicker Related to the date/time picker component vue 3 Related to the vue 3 migration
Projects
None yet
Milestone
9.0.0
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@raimund-schluessler @JuliaKirschenheuter @skjnldsv @ShGKme