Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(NcAppNavigation): Make the navigation toggle accessible again when closed #4546

Merged
merged 1 commit into from Sep 19, 2023

Conversation

susnux
Copy link
Contributor

@susnux susnux commented Sep 19, 2023

☑️ Resolves

Make only the content of the navigation inert when closed but not the wrapper which includes the toggle

🖼️ Screenshots

vokoscreenNG-2023-09-19_21-39-20.mp4

🏁 Checklist

  • ⛑️ Tests are included or are not applicable
  • 📘 Component documentation has been extended, updated or is not applicable

…n closed

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
@susnux susnux added bug Something isn't working 3. to review Waiting for reviews feature: app-navigation Related to the app-navigation component regression Regression of a previous working feature labels Sep 19, 2023
@susnux susnux added this to the 8.0.0 milestone Sep 19, 2023
@susnux
Copy link
Contributor Author

susnux commented Sep 19, 2023

/backport to next

Copy link
Contributor

@szaimen szaimen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and works

@szaimen szaimen requested a review from st3iny September 19, 2023 20:00
@raimund-schluessler raimund-schluessler merged commit df8bb3f into master Sep 19, 2023
15 checks passed
@raimund-schluessler raimund-schluessler deleted the fix/nav-toggle branch September 19, 2023 20:11
@raimund-schluessler
Copy link
Contributor

/backport to next

Backport bot is still dead, I think.

@susnux
Copy link
Contributor Author

susnux commented Sep 20, 2023

/backport to next

Backport bot is still dead, I think.

Sadly it is, but at least it is a reminder to backport 😅

@Pytal Pytal mentioned this pull request Sep 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews bug Something isn't working feature: app-navigation Related to the app-navigation component regression Regression of a previous working feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

NcNavigation - Close/Open Button
3 participants