Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

enh(NcAppSidebarTabs): Make tab navigation accessible #4663

Merged
merged 8 commits into from Oct 19, 2023
Merged

enh(NcAppSidebarTabs): Make tab navigation accessible #4663

merged 8 commits into from Oct 19, 2023

Conversation

Pytal
Copy link
Contributor

@Pytal Pytal commented Oct 18, 2023 •
edited

Summary

🏚️ Before 🏡 After
image image
  • Fix glitchy Tab + ↑ ↓ ← → navigation, now only ↑ ↓ ← → will change tab focus
  • Fix tabpanel association
  • Test on server
  • Test with NVDA
  • Update tests

No visual changes

🏁 Checklist

  • ⛑️ Tests are included or are not applicable
  • 📘 Component documentation has been extended, updated or is not applicable

@Pytal Pytal added bug Something isn't working enhancement New feature or request 3. to review Waiting for reviews feature: app-sidebar Related to the app-sidebar component accessibility Making sure we design for the widest range of people possible, including those who have disabilities feature: checkbox-radio-switch Related to the checkbox-radio-switch component labels Oct 18, 2023
@Pytal Pytal added this to the 8.0.0 milestone Oct 18, 2023
@Pytal Pytal self-assigned this Oct 18, 2023
@Pytal Pytal mentioned this pull request Oct 18, 2023
Closed
7 tasks
@Pytal
fix(NcAppSidebarTabs): Adjust styles
8f6abb6 
Signed-off-by: Christopher Ng <chrng8@gmail.com>
@Pytal
feat(NcCheckboxRadioSwitch): Sidebar tab usage
5f8f3e2 
Signed-off-by: Christopher Ng <chrng8@gmail.com>
@Pytal
feat(NcCheckboxRadioSwitch): Add NcCheckboxContent component
e73200c 
Signed-off-by: Christopher Ng <chrng8@gmail.com>
@Pytal
fix(NcAppSidebarTabs): Always add aria-selected
a2e2c16 
Signed-off-by: Christopher Ng <chrng8@gmail.com>
@Pytal
fix(NcAppSidebarTabs): Tests
7538063 
Signed-off-by: Christopher Ng <chrng8@gmail.com>
@Pytal
fix(NcCheckboxRadioSwitch): Enforce button type
e9281b6 
Signed-off-by: Christopher Ng <chrng8@gmail.com>
@Pytal
fix(NcAppSidebarTabs): Correct association between tab button and tab…
012b900 
…panel

Signed-off-by: Christopher Ng <chrng8@gmail.com>
@Pytal
fix(NcCheckboxRadioSwitch): Adjust styles
ca5fda8 
Signed-off-by: Christopher Ng <chrng8@gmail.com>
@susnux susnux merged commit b4bca69 into master Oct 19, 2023
15 checks passed
@susnux susnux deleted the enh/a11y/sidebar-tabs branch October 19, 2023 16:53
@Pytal Pytal mentioned this pull request Oct 23, 2023
Merged
This was referenced Oct 23, 2023
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@susnux susnux susnux approved these changes

@JuliaKirschenheuter JuliaKirschenheuter JuliaKirschenheuter approved these changes

@ShGKme ShGKme ShGKme approved these changes

@artonge artonge Awaiting requested review from artonge

Assignees

@Pytal Pytal

Labels
3. to review Waiting for reviews accessibility Making sure we design for the widest range of people possible, including those who have disabilities bug Something isn't working enhancement New feature or request feature: app-sidebar Related to the app-sidebar component feature: checkbox-radio-switch Related to the checkbox-radio-switch component
Projects
None yet
Milestone
8.0.0
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@Pytal @susnux @JuliaKirschenheuter @ShGKme