Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix input field trailing button alignment #4770

Merged
merged 2 commits into from
Nov 8, 2023
Merged

Fix input field trailing button alignment #4770

merged 2 commits into from
Nov 8, 2023

Conversation

marcoambrosini
Copy link
Contributor

@marcoambrosini marcoambrosini commented Nov 8, 2023 •
edited by susnux
Loading

☑️ Resolves

🖼️ Screenshots

🏚️ Before 🏡 After
image image

🏁 Checklist

  • ⛑️ Tests are included or are not applicable
  • 📘 Component documentation has been extended, updated or is not applicable

@marcoambrosini
Fix trailing button alignment
71d4ed6 
Signed-off-by: Marco <marcoambrosini@icloud.com>
@marcoambrosini marcoambrosini mentioned this pull request Nov 8, 2023
Merged
@marcoambrosini marcoambrosini changed the title Fix trailing button alignment Fix input field trailing button alignment Nov 8, 2023
@marcoambrosini marcoambrosini self-assigned this Nov 8, 2023
@marcoambrosini marcoambrosini marked this pull request as ready for review November 8, 2023 01:02
@marcoambrosini marcoambrosini added bug Something isn't working 3. to review Waiting for reviews labels Nov 8, 2023
@susnux susnux requested a review from Pytal November 8, 2023 01:46
@susnux susnux added this to the 8.0.0 milestone Nov 8, 2023
@susnux susnux mentioned this pull request Nov 8, 2023
Merged
16 tasks
@Pytal Pytal added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Nov 8, 2023
@Pytal Pytal merged commit ac07f8a into master Nov 8, 2023
16 checks passed
@Pytal Pytal deleted the bugfix/input-field-design-fixes branch November 8, 2023 02:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@susnux susnux susnux approved these changes

@Pytal Pytal Pytal approved these changes

@ShGKme ShGKme Awaiting requested review from ShGKme

@JuliaKirschenheuter JuliaKirschenheuter Awaiting requested review from JuliaKirschenheuter

Assignees

@marcoambrosini marcoambrosini

Labels
4. to release Ready to be released and/or waiting for tests to finish bug Something isn't working
Projects
None yet
Milestone
8.0.0
Development

Successfully merging this pull request may close these issues.

NcInputField design issues
3 participants
@marcoambrosini @susnux @Pytal