Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix unregisterSection Bug in NcAppSettingsDialog #4808

Closed
wants to merge 1 commit into from
Closed

Fix unregisterSection Bug in NcAppSettingsDialog #4808

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/components/NcAppSettingsDialog/NcAppSettingsDialog.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -251,7 +251,7 @@
scroller: null,
/**
* Currently registered settings sections
* @type {{ id: string, name: string, icon?: VNode[] }}

Check warning on line 254 in src/components/NcAppSettingsDialog/NcAppSettingsDialog.vue

View workflow job for this annotation

GitHub Actions / eslint 

The type 'VNode' is undefined
*/
sections: [],
}
Expand Down Expand Up @@ -338,7 +338,7 @@
* @param {string} id The section ID
*/
unregisterSection(id) {
this.sections = this.sections.filter(({ id: otherId }) => id === otherId)
this.sections = this.sections.filter(({ id: otherId }) => id !== otherId)
},

/**
Expand Down
Loading