fix(NcAppSidebarTabs): override tabs styles only tablist navigation #4823
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ShGKme
changed the title
…bslist nav Otherwise NcCheckboxRadioSwitch-s in tab content are also overridden Signed-off-by: Grigorii K. Shartsev <me@shgk.me>
ShGKme
force-pushed
the
fix/app-sidebar-tabs--styles-leak
branch
from
ba74d99
to
3ea472b
Compare
ShGKme
requested review from
marcoambrosini,
jancborchardt,
susnux,
juliushaertl,
JuliaKirschenheuter,
Pytal,
szaimen and
Antreesy
ShGKme
added
bug
JuliaKirschenheuter
approved these changes
Nov 15, 2023
marcoambrosini
approved these changes
Nov 15, 2023
ShGKme
changed the title
szaimen
reviewed
Nov 16, 2023
| } | ||
| &.checkbox-radio-switch--checked .checkbox-radio-switch__content{ | ||
| background: transparent !important; | ||
| color: var(--color-main-text) !important; |
There was a problem hiding this comment.
The correct text color in that case would have been --color-primary-element-text
There was a problem hiding this comment.
would you mind creating a PR for this? 🙏
szaimen
reviewed
Nov 16, 2023
| margin: 0 !important; | ||
| border-bottom: var(--default-grid-baseline) solid transparent !important; | ||
| .checkbox-content__icon--checked > * { | ||
| color: var(--color-main-text) !important; |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
☑️ Resolves
NcCheckboxRadioSwitchstyles are overridden insideNcAppSidebarTab#4822🖼️ Screenshots
🚧 Tasks
:deepNcCheckboxRadioSwitchstyles only inside tabslist navigation, not inside all the tab, including tab content🏁 Checklist