Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create scrollable content via min-height over sidebar and settings … #4825

Conversation

JuliaKirschenheuter
Copy link
Contributor

Create scrollable content via min-height over sidebar and settings dialog on small screens

☑️ Resolves

🖼️ Screenshots

🏚️ Before

Peek 2023-11-15 16-57

Peek 2023-11-15 16-56

🏡 After

Peek 2023-11-15 16-53

Peek 2023-11-15 16-52

🏁 Checklist

  • ⛑️ Tests are included or are not applicable
  • 📘 Component documentation has been extended, updated or is not applicable

@susnux
Copy link
Contributor

susnux commented Nov 16, 2023

sorry lets revert you fixup comment, my comment was wrong. If we set this on the dialog even small text dialogs have at least that height which looks weird.
You initial version was already perfect 🙈

…dialog on small screens

Signed-off-by: julia.kirschenheuter <julia.kirschenheuter@nextcloud.com>
@JuliaKirschenheuter JuliaKirschenheuter force-pushed the fix/41504-Create_scrollable_content_over_sidebar_and_settings_dialog_on_small_screens_ branch from fbe8c6a to 73fa6b1 Compare November 16, 2023 13:11
@susnux susnux merged commit 5db6b10 into master Nov 16, 2023
15 checks passed
@susnux susnux deleted the fix/41504-Create_scrollable_content_over_sidebar_and_settings_dialog_on_small_screens_ branch November 16, 2023 13:14
@jancborchardt
Copy link
Contributor

Isn’t there being 2 scrollable contents right within each other quite a no-go? Having to scroll twice and the possibility of getting those mixed up (and have content hidden) is quite confusing.

@ShGKme
Copy link
Contributor

ShGKme commented Nov 16, 2023

Isn’t there being 2 scrollable contents right within each other quite a no-go? Having to scroll twice and the possibility of getting those mixed up (and have content hidden) is quite confusing.

Yes, there will be 2 scrollable contents.

But this is the easiest solution we found to make pages usable on a 320x256 screen (a11y requirement).

As an alternative to the settings dialog, we could remove NcModal header, that could give as some pixels. But I don't see any alternative for the sidebar.

Do you have any ideas? @jancborchardt

@jancborchardt
Copy link
Contributor

Will this 2-scrollable-areas situation only appear at these small sizes or before already?

If only at these small sizes I'd say it's fine. If it appears for everyone even at desktop size or a bit smaller screen (considering sidebar is only a part of it), we'd have to check.

@ShGKme
Copy link
Contributor

ShGKme commented Nov 16, 2023

Will this 2-scrollable-areas situation only appear at these small sizes or before already?

Before.

The minimal height for content was 0px before, which is unreadable.

With this PR it is 256px. It depends on sidebar content, but for a file nav header + sidebar header + tabs + padding = ~310px. So it adds scrolling from ~570px.

What the minimal height could you suggest for the sidebar content?

@susnux susnux mentioned this pull request Nov 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BITV]: Create scrollable content over sidebar and settings dialog on small screens
5 participants