Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(NcRichcontenteditable): remove placeholder attr #4843

Merged

Conversation

ShGKme
Copy link
Contributor

@ShGKme ShGKme commented Nov 16, 2023

☑️ Resolves

This attribute is not valid on div[richcontenteditable] and was used only to pass value to css.

🖼️ Screenshots

No visual changes

🚧 Tasks

  • Remove placeholder and use aria-placeholder to pass value to CSS

🏁 Checklist

  • ⛑️ Tests are included or are not applicable
  • 📘 Component documentation has been extended, updated or is not applicable

This attribute is not valid on `div[richcontenteditable]` and was used only to pass value to css.

Signed-off-by: Grigorii K. Shartsev <me@shgk.me>
@ShGKme ShGKme added bug Something isn't working 3. to review Waiting for reviews accessibility Making sure we design for the widest range of people possible, including those who have disabilities feature: rich-contenteditable Related to the rich-contenteditable components labels Nov 16, 2023
@ShGKme ShGKme added this to the 8.1.1 milestone Nov 16, 2023
@ShGKme ShGKme self-assigned this Nov 16, 2023
@raimund-schluessler raimund-schluessler merged commit 36f2e72 into master Nov 17, 2023
15 checks passed
@raimund-schluessler raimund-schluessler deleted the fix/nc-richcontenteditable--remove-placeholder branch November 17, 2023 08:04
@susnux susnux mentioned this pull request Nov 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews accessibility Making sure we design for the widest range of people possible, including those who have disabilities bug Something isn't working feature: rich-contenteditable Related to the rich-contenteditable components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants