fix(NcInput): input disabled appearance #5000
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Marco Ambrosini <marcoambrosini@proton.me>
|
nextcloud/server#42498 is about generic HTML inputs, not NcInput. |
|
Congrats on the #5000 🎉🎉🎉 |
|
Looks like the text will not satisfy the color contrast? we should probably stick with max-contrast? |
nimishavijay
approved these changes
Jan 9, 2024
There was a problem hiding this comment.
Disabled buttons seem to not have to meet the contrast requirement (see discussion in another org), so I think we should be good
susnux
approved these changes
Jan 15, 2024
Merged
susnux
changed the title
susnux
added
bug
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
☑️ Resolves
🖼️ Screenshots
@nextcloud-libraries/designers