New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(NcPopover): check trigger a11y compatible with Vue 3 #5110
Conversation
Signed-off-by: Grigorii K. Shartsev <me@shgk.me>
871f686
to
5391d20
Compare
Shouldn't this trigger the warning? But it does not in the docs (unless they aren't built as debug, but I think they are). It also gives no warning for <template>
<div style="display: flex">
<NcPopover>
<!-- Take "attrs" from the slot props -->
<template #trigger>
<!-- Bind attrs as the button attrs -->
<button>
I am a custom button in the trigger2
</button>
</template>
Hi! 🚀
</NcPopover>
</div>
</template> |
On an unrelated note, this example triggers a |
Weird. I guess https://deploy-preview-5110--nextcloud-vue-components.netlify.app/#/Components/NcPopover is not debug mode then. |
It is... Let me check |
Oh, yes. It is in |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works locally 👍
☑️ Resolves
NcPopoverTriggerProvider
#5108Popover content is usually only the trigger. So no need to check content in a slot component.
Trigger's parent DOM node is accessible by
$refs
of Floating-Vue.For Vue 3 only requires to change
refs
from Floating-Vue.🏁 Checklist