Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(NcRichText): handle internal links with Vue Router #5246

Merged
merged 1 commit into from
Feb 18, 2024

Conversation

Antreesy
Copy link
Contributor

@Antreesy Antreesy commented Feb 12, 2024

☑️ Resolves

🖼️ Screenshots

Tested against Talk:

  • link to app root /apps/spreed
  • links between different conversation /call/{token}
  • links between specific messages /call/{token}#message_id
  • both inline links and previews in NcReferenceWidget

Cursor is missing, but browser address bar is visible

router-links.mp4

🚧 Tasks

  • Code review
  • Test coverage

🏁 Checklist

  • ⛑️ Tests are included or are not applicable
  • 📘 Component documentation has been extended, updated or is not applicable
  • 3️⃣ Backport to next requested with a Vue 3 upgrade

@Antreesy Antreesy added enhancement New feature or request 3. to review Waiting for reviews feature: richtext Related to the richtext component labels Feb 12, 2024
@Antreesy Antreesy added this to the 8.7.0 milestone Feb 12, 2024
@Antreesy Antreesy self-assigned this Feb 12, 2024
Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>
@Antreesy Antreesy force-pushed the feat/10565/handle-internal-links branch from c92a651 to 985c0fb Compare February 12, 2024 15:07
Copy link
Contributor

@juliushaertl juliushaertl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice 👍

@susnux susnux merged commit 3848adc into master Feb 18, 2024
18 checks passed
@susnux susnux deleted the feat/10565/handle-internal-links branch February 18, 2024 10:19
@Antreesy
Copy link
Contributor Author

/backport to next

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews enhancement New feature or request feature: richtext Related to the richtext component
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants