Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(NcSelect): handle text overflow in NcSelect #5325

Merged
merged 1 commit into from Feb 29, 2024
Merged

fix(NcSelect): handle text overflow in NcSelect #5325

merged 1 commit into from Feb 29, 2024

Conversation

hamza221
Copy link
Contributor

@hamza221 hamza221 commented Feb 29, 2024 •
edited by susnux

🖼️ Screenshots

🏚️ Before 🏡 After
image image

🚧 Tasks

  • ...

🏁 Checklist

  • ⛑️ Tests are included or are not applicable
  • 📘 Component documentation has been extended, updated or is not applicable
  • 3️⃣ Backport to next requested with a Vue 3 upgrade

@hamza221
Enh: handle text overflow in NcSelect
d63e7a2 
Signed-off-by: Hamza Mahjoubi <hamzamahjoubi221@gmail.com>
@hamza221 hamza221 added enhancement New feature or request 3. to review Waiting for reviews feature: select Related to the NcSelect* components labels Feb 29, 2024
@hamza221 hamza221 requested a review from Pytal February 29, 2024 10:23
@hamza221 hamza221 self-assigned this Feb 29, 2024
@hamza221 hamza221 marked this pull request as ready for review February 29, 2024 10:23
@hamza221 hamza221 mentioned this pull request Feb 29, 2024
Merged
20 tasks
@susnux susnux merged commit 74b28c3 into master Feb 29, 2024
19 checks passed
@susnux susnux deleted the enh/text-overflow-ncselect branch February 29, 2024 13:00
@susnux susnux added bug Something isn't working and removed enhancement New feature or request labels Feb 29, 2024
@susnux susnux changed the title Enh: handle text overflow in NcSelect fix(NcSelect): handle text overflow in NcSelect Feb 29, 2024
@ShGKme ShGKme mentioned this pull request Feb 29, 2024
Merged
@ShGKme ShGKme added this to the 8.8.1 milestone Feb 29, 2024
@ShGKme
Copy link
Contributor

ShGKme commented Mar 8, 2024

/backport to next

@backportbot backportbot bot mentioned this pull request Mar 8, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@susnux susnux susnux approved these changes

@ShGKme ShGKme ShGKme approved these changes

@Pytal Pytal Awaiting requested review from Pytal

Assignees

@hamza221 hamza221

Labels
3. to review Waiting for reviews bug Something isn't working feature: select Related to the NcSelect* components
Projects
None yet
Milestone
8.8.1
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@hamza221 @ShGKme @susnux