Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: scope component breaking NcModal and NcDateTimePickers #5331

Merged
merged 1 commit into from Feb 29, 2024

Conversation

ShGKme
Copy link
Contributor

@ShGKme ShGKme commented Feb 29, 2024

🏁 Checklist

  • ⛑️ Tests are included or are not applicable
  • 📘 Component documentation has been extended, updated or is not applicable
  • 3️⃣ Backport to next requested with a Vue 3 upgrade

Signed-off-by: Grigorii K. Shartsev <me@shgk.me>
@ShGKme ShGKme added bug Something isn't working 3. to review Waiting for reviews labels Feb 29, 2024
@ShGKme ShGKme self-assigned this Feb 29, 2024
@ShGKme ShGKme changed the title fix: scope component breaking NcModal, NcDateTimePicker, NcDateTimePi… fix: scope component breaking NcModal and NcDateTimePickers Feb 29, 2024
Copy link
Contributor

@Antreesy Antreesy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Jest in Talk isn't complaining anymore

@susnux susnux merged commit ecc619e into master Feb 29, 2024
19 checks passed
@susnux susnux deleted the fix/scope-component-util branch February 29, 2024 13:52
@ShGKme ShGKme mentioned this pull request Feb 29, 2024
@ShGKme ShGKme added this to the 8.8.1 milestone Feb 29, 2024
@ShGKme
Copy link
Contributor Author

ShGKme commented Mar 8, 2024

/backport to next

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants