Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(NcUserStatusicon): set status icons size explicitly #5390

Merged
merged 1 commit into from Mar 11, 2024
Merged

fix(NcUserStatusicon): set status icons size explicitly #5390

merged 1 commit into from Mar 11, 2024

Conversation

Antreesy
Copy link
Contributor

☑️ Resolves

  • Fix User status broken on safari #5386
    • As SVG is inserted as plain HTML into DOM, all styles should be provided from parent elements (Vue component) or by SVG itself
    • Turns out Safari doesn't adjust SVG element sizes to fit content inside of it
    • P.S Screenshots are mocked, but output is the same

🖼️ Screenshots

🏚️ Before 🏡 After
image image

🏁 Checklist

  • ⛑️ Tests are included or are not applicable
  • 📘 Component documentation has been extended, updated or is not applicable
  • 3️⃣ Backport to next requested with a Vue 3 upgrade

@Antreesy
fix(NcUserStatusicon): set status icons size explicitly
958d5c0 
Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>
@Antreesy Antreesy added bug Something isn't working 3. to review Waiting for reviews labels Mar 11, 2024
@Antreesy Antreesy added this to the 8.10.0 milestone Mar 11, 2024
@Antreesy Antreesy requested a review from Pytal March 11, 2024 09:32
@Antreesy Antreesy self-assigned this Mar 11, 2024
nickvergessen
nickvergessen approved these changes Mar 11, 2024
View reviewed changes
Copy link
Contributor

@nickvergessen nickvergessen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah that old bug again

@nickvergessen
Copy link
Contributor

/backport to next

@Antreesy Antreesy merged commit ff6664b into master Mar 11, 2024
18 checks passed
@Antreesy Antreesy deleted the fix/5386/broken-status branch March 11, 2024 10:33
@backportbot backportbot bot mentioned this pull request Mar 11, 2024
Merged
@ShGKme ShGKme mentioned this pull request Mar 11, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nickvergessen nickvergessen nickvergessen approved these changes

@mejo- mejo- mejo- approved these changes

@Pytal Pytal Awaiting requested review from Pytal

Assignees

@Antreesy Antreesy

Labels
3. to review Waiting for reviews bug Something isn't working
Projects
None yet
Milestone
8.10.0
Development

Successfully merging this pull request may close these issues.

User status broken on safari
3 participants
@Antreesy @nickvergessen @mejo-