fix(NcCheckboxRadioSwitch): Pass attrs to input if available
#5507
Conversation
susnux
added
bug
|
/backport to next |
If not button type, pass the attrs to the input element to allow setting aria tags like `aria-invalid` and `aria-errormessage` Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
susnux
force-pushed
the
fix/checkbox-attrs
branch
from
d3ea385
to
395fc5f
Compare
They are as in this case it is the root element. |
|
we maybe should add consistent props for all input elements to have some focus and validation API independent of the implementation. |
| // We need to pass attributes to the input element | ||
| inheritAttrs: false, |
There was a problem hiding this comment.
They are as in this case it is the root element.
But it is disabled via inheritAttrs: false here
There was a problem hiding this comment.
For vue2 class and style are passed to the root as they are not attrs but somewhat special
There was a problem hiding this comment.
There was a problem hiding this comment.
Why don't pass to the button as well?
Here I meant the attrs, not only class/style.
There was a problem hiding this comment.
Currently there is a new possibility to pass attrs to input, but the possibility to pass attrs to the button has been disabled.
There was a problem hiding this comment.
No for button type they are passed:
https://github.com/nextcloud-libraries/nextcloud-vue/pull/5507/files#diff-80b068a320cd09d28f4f8913f4c77c73754bed31f69a9b3a25353059d8573623R279
There was a problem hiding this comment.
So class & style are always set to the wrapper.
attrs are passed to the wrapper (the button) for button type and to the input for other types.
There was a problem hiding this comment.
Oh, sorry, missed this line.
☑️ Resolves
I would expect the attrs on the input element to allow any aria attributes.
So if not button type, pass the attrs to the input element to allow setting aria tags like
aria-invalidandaria-errormessage🏁 Checklist
nextrequested with a Vue 3 upgrade