Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: japanese system tags translation #5728

Merged
merged 1 commit into from
Jun 25, 2024
Merged

fix: japanese system tags translation #5728

merged 1 commit into from
Jun 25, 2024

Conversation

hamza221
Copy link
Contributor

@hamza221 hamza221 commented Jun 21, 2024 •
edited
Loading

☑️ Resolves

  • Fix #…

🖼️ Screenshots

🏚️ Before 🏡 After
image image

🚧 Tasks

  • ...

🏁 Checklist

  • ⛑️ Tests are included or are not applicable
  • 📘 Component documentation has been extended, updated or is not applicable
  • 3️⃣ Backport to next requested with a Vue 3 upgrade

@hamza221
fix: japanese system tags translation
32bd448 
Signed-off-by: Hamza Mahjoubi <hamzamahjoubi221@gmail.com>
@hamza221 hamza221 self-assigned this Jun 21, 2024
@hamza221 hamza221 added 3. to review Waiting for reviews bug Something isn't working labels Jun 21, 2024
@hamza221
Copy link
Contributor Author

/backport to next

@hamza221
Copy link
Contributor Author

/backport to stable7

Antreesy
Antreesy reviewed Jun 21, 2024
View reviewed changes
Copy link
Contributor

@Antreesy Antreesy left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Haven't found any other broken strings, so should be good to go
Since Nextcloud v28 is on 8.11.2, can we do a 8.11.3 release with that PR only, maybe?

@susnux
Copy link
Contributor

susnux commented Jun 21, 2024

This will be directly overwritten again by transifex.
Instead you need to fix this on transifex directly

@Antreesy

This comment was marked as resolved.

Sign in to view
@hamza221
Copy link
Contributor Author

hamza221 commented Jun 21, 2024 •
edited
Loading

done, they need to be reviewed though
image

@susnux susnux merged commit 183ed10 into master Jun 25, 2024
19 checks passed
@susnux susnux deleted the fix/japanese-translation branch June 25, 2024 13:52
This was referenced Jun 25, 2024
Merged
Merged
@ShGKme
Copy link
Contributor

ShGKme commented Jun 25, 2024

Won't it be reverted by any translation update from transifex? Why change from here?

@susnux
Copy link
Contributor

susnux commented Jun 25, 2024

Won't it be reverted by any translation update from transifex? Why change from here?

Customer issue. We need a fix now and even if it is fixed on transifex since 4 days it is not synced back to this repo

@hamza221 hamza221 mentioned this pull request Jul 4, 2024
Closed
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@susnux susnux susnux approved these changes

@Antreesy Antreesy Antreesy approved these changes

@ShGKme ShGKme Awaiting requested review from ShGKme

Assignees

@hamza221 hamza221

Labels
3. to review Waiting for reviews bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@hamza221 @susnux @Antreesy @ShGKme