feat(config): introduce configuration builder #1053
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Altahrim
force-pushed
the
feat/config-builder
branch
5 times, most recently
from
68d8594
to
6d77807
Compare
Altahrim
force-pushed
the
feat/config-builder
branch
2 times, most recently
from
d91c525
to
9f85c31
Compare
Altahrim
force-pushed
the
feat/config-builder
branch
from
9f85c31
to
df16b75
Compare
This was referenced May 19, 2024
Open
|
Nice! Since you're already stuffing the branch eol date into the json, this would be an ideal opportunity for #1050. This would let me do this: nextcloud/server#45402 (comment) |
Altahrim
force-pushed
the
feat/config-builder
branch
2 times, most recently
from
c3b6815
to
c32aa58
Compare
skjnldsv
reviewed
May 22, 2024
Altahrim
force-pushed
the
feat/config-builder
branch
2 times, most recently
from
8ea3d28
to
280a290
Compare
|
Rebased for latest |
AndyScherzinger
approved these changes
May 22, 2024
Altahrim
force-pushed
the
feat/config-builder
branch
2 times, most recently
from
db138d4
to
7d8f66f
Compare
Signed-off-by: Benjamin Gaussorgues <benjamin.gaussorgues@nextcloud.com>
Signed-off-by: Benjamin Gaussorgues <benjamin.gaussorgues@nextcloud.com>
Altahrim
force-pushed
the
feat/config-builder
branch
from
11aaab6
to
639a566
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Content
Introduce a configuration builder based on JSON files:
major_versions.jsondeclare all Nextcloud major versions with end of life and minimal supported PHP versionreleases.jsonlist all releases with their attributes (signature, internal version number and deploy percentage)The builder should be able to generate the
config.phpwe are used to.TODO
README.md