Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nextcloud: update to 16.0.5 #1002

Merged
merged 1 commit into from
Sep 27, 2019

Conversation

kyrofa
Copy link
Member

@kyrofa kyrofa commented May 16, 2019

This PR resolves #972 by updating Nextcloud to the latest v16 release.

@kyrofa
Copy link
Member Author

kyrofa commented May 17, 2019

@pachulo, @r4co0n would appreciate your taking this for a spin.

@kyrofa kyrofa force-pushed the dependency/972/nextcloud_16 branch from a053f53 to f3ce815 Compare May 17, 2019 11:15
@pachulo
Copy link
Member

pachulo commented May 17, 2019

I would like to, but I'm running my instance on an arm64 installation, so I cannot test the snap builder snap...besides that, it is still at “Expected — Waiting for status to be reported” state, maybe there were some problems with it?

@kyrofa
Copy link
Member Author

kyrofa commented May 17, 2019 via email

@kyrofa kyrofa force-pushed the dependency/972/nextcloud_16 branch 2 times, most recently from 62a0a15 to cf7999e Compare May 17, 2019 21:29
@pachulo
Copy link
Member

pachulo commented May 17, 2019

OK, did the refresh from 15.0.7 and everything went OK, but I've observed that some apps seem to be de-activated before being updated...and afterwards you need to activate them manually, including essential ones like “Calendar”.
Besides that, “End-To-End Encryption” seems to be not compatible yet: https://github.com/nextcloud/end_to_end_encryption/releases
Is that something we want to bear with?

@kyrofa
Copy link
Member Author

kyrofa commented May 19, 2019

Wait, so what, if you have encryption enabled and you upgrade, you just can't access stuff?

@pachulo
Copy link
Member

pachulo commented May 19, 2019

Well, it should work anyway if activated manually:

but not the best experience IMHO...

@kyrofa
Copy link
Member Author

kyrofa commented May 19, 2019

Yeah that's not cool at all. Sounds like we agree we don't want to expose our users to that, so we're in a holding pattern for a bit. I'll release 15.0.8 while we wait.

@kyrofa kyrofa force-pushed the dependency/972/nextcloud_16 branch from cf7999e to b596f05 Compare June 7, 2019 15:31
@TarSzator
Copy link

Added a comment here, because we are still waiting for this issue right?
nextcloud/end_to_end_encryption#108 (comment)

@kyrofa
Copy link
Member Author

kyrofa commented Jun 25, 2019

Indeed, yes. It's been a long time since they released 16.0.1, too, I wonder if they're all focusing on something particular. Just to make sure: you know you can refresh to 16/candidate if you want v16 now, right?

@kyrofa kyrofa force-pushed the dependency/972/nextcloud_16 branch from b596f05 to 5cd767b Compare July 4, 2019 16:48
@kyrofa kyrofa changed the title nextcloud: update to 16.0.1 nextcloud: update to 16.0.2 Jul 4, 2019
@kyrofa kyrofa force-pushed the dependency/972/nextcloud_16 branch 3 times, most recently from e023e90 to 5fbbcd1 Compare July 4, 2019 17:35
@kyrofa
Copy link
Member Author

kyrofa commented Jul 5, 2019

Alright folks (particularly @pachulo), let's test this again now that v16.0.2 is out. Ignore any errors from the snap builder, I built these all the old way for all architectures in the beta/pr-1002 channel:

$ sudo snap install nextcloud --channel=beta/pr-1002

Or, if you already have it installed:

$ sudo snap refresh nextcloud --channel=beta/pr-1002

@kyrofa kyrofa mentioned this pull request Jul 5, 2019
@pachulo
Copy link
Member

pachulo commented Jul 5, 2019

Tested this and I'm still seeing the "Activate not tested apps" button for Calendar, Quota warning, Talk & End-to-End Encryption...I'm still not sure that this is what we want for our users, even though is not a fault of the snap.
At least for the first 3, updating them and reloading the page seems to get rid of the button, but in my case they needed to be re-activated anyway...how can this still be the case for such popular applications?

It's a real pity, because loading times of nextcloud 16.0.x seems to be lower than with 15.0.x

@kyrofa
Copy link
Member Author

kyrofa commented Jul 6, 2019

Actually, 16.0.2 is entirely busted due to nextcloud/server#16238 (as is 15.0.9). I'm not sure what's going on with quality control over there 😞 . Is "install, login, and attempt to upload something" not a part of the QA process before shipping the release? Guess we continue that holding pattern.

@kyrofa
Copy link
Member Author

kyrofa commented Jul 6, 2019

At least for the first 3, updating them and reloading the page seems to get rid of the button [...]

I suspect that issue will go away if we can ship an updated v15 snap before updating to v16.

@manuee
Copy link

manuee commented Jul 6, 2019

Hi, just wanted to point out that Nextcloud 15 end of life is scheduled for 2019-12:
https://docs.nextcloud.com/server/16/admin_manual/release_schedule.html

That said, thanks for playing it safe with this, makes me feel more confident on using the snap.

@kyrofa
Copy link
Member Author

kyrofa commented Jul 6, 2019

Hi, just wanted to point out that Nextcloud 15 end of life is scheduled for 2019-12 [...]

Oh yeah, don't worry, we want to update to v16 as soon as possible! We just need a not-broken release first (that includes the apps being ready for it). I expect this will happen in the "weeks" timeframe-- we shouldn't even approach v15 end-of-life.

That said, thanks for playing it safe with this [...]

Of course! We all use the snap, too. It's in all our best interests that we collectively test things out and act as the best gate-keepers we can.

@manuee
Copy link

manuee commented Jul 6, 2019

Hi, just wanted to point out that Nextcloud 15 end of life is scheduled for 2019-12 [...]

Oh yeah, don't worry, we want to update to v16 as soon as possible! We just need a not-broken release first (that includes the apps being ready for it). I expect this will happen in the "weeks" timeframe-- we shouldn't even approach v15 end-of-life.

Ah great to know, thanks!

@pachulo
Copy link
Member

pachulo commented Jul 9, 2019

It seems that 16.0.3 & 15.0.10 are already here...

@kyrofa kyrofa force-pushed the dependency/972/nextcloud_16 branch from 5fbbcd1 to 52e6cef Compare July 9, 2019 14:47
@kyrofa kyrofa changed the title nextcloud: update to 16.0.2 nextcloud: update to 16.0.3 Jul 9, 2019
@stondino00
Copy link
Contributor

Can we try out 16.0.4 in this channel? I'm not showing any issues so far with php 7.2.21 and apache 2.4.41 with nextcloud 16.0.3. Thanks

@the-sane
Copy link

@stondino00 He's trying very hard to get the needed upstream fix into 16.0.4 so that it can go to the stable channel when it's released.

@kyrofa kyrofa force-pushed the dependency/972/nextcloud_16 branch from afdd59e to 204af17 Compare August 16, 2019 15:06
@kyrofa kyrofa changed the title nextcloud: update to 16.0.3 nextcloud: update to 16.0.4 Aug 16, 2019
@kyrofa kyrofa force-pushed the dependency/972/nextcloud_16 branch from 204af17 to 664f271 Compare August 16, 2019 21:24
@kyrofa
Copy link
Member Author

kyrofa commented Aug 16, 2019

He's trying very hard to get the needed upstream fix into 16.0.4 [...]

16.0.5 now 😢 .

@alexander-rieder
Copy link

so what is the roadmap? Can i help in any way?

@kyrofa
Copy link
Member Author

kyrofa commented Aug 27, 2019

We're still stuck on this comment. We need upstream to land that PR and make a new release containing it.

@Bleuzen
Copy link

Bleuzen commented Sep 1, 2019

Can the 16/candidate channel be updated with 16.0.4 for now? It is still on 16.0.3.

@kyrofa
Copy link
Member Author

kyrofa commented Sep 4, 2019

Alright, that PR was finally merged upstream, just waiting for 16.0.5 now.

@kyrofa
Copy link
Member Author

kyrofa commented Sep 6, 2019

Ah, it's beautiful, got a preview using 16/edge (daily v16 builds):

$ sudo snap install nextcloud

(install calendar app)

$ sudo snap refresh nextcloud --channel=16/edge
$ journalctl -f -u snap.nextcloud.apache.service
<snip>
Sep 06 15:36:37 protege nextcloud.apache[460]: Disabled incompatible app: calendar
<snip>
Sep 06 15:36:42 protege nextcloud.apache[460]: Checking for update of app calendar in appstore
Sep 06 15:36:42 protege nextcloud.apache[460]: Update app calendar from appstore
Sep 06 15:36:44 protege nextcloud.apache[460]: Checked for update of app "calendar" in appstore

Login, and calendar is still there, fully updated, and works great.

@pachulo
Copy link
Member

pachulo commented Sep 7, 2019

Thanks a lot for this @kyrofa !

@pachulo
Copy link
Member

pachulo commented Sep 26, 2019

Is this the real life? XD
https://github.com/nextcloud/server/releases/tag/v16.0.5

@kyrofa kyrofa changed the title nextcloud: update to 16.0.4 nextcloud: update to 16.0.5 Sep 26, 2019
Resolve nextcloud-snap#972

Signed-off-by: Kyle Fazzari <kyrofa@ubuntu.com>
@kyrofa
Copy link
Member Author

kyrofa commented Sep 26, 2019

Alright folks, despite what the Snap Builder says, this is ready for testing on all supported architectures:

$ sudo snap install nextcloud --channel=beta/pr-1002

Or if you already have it installed:

$ sudo snap refresh nextcloud --channel=beta/pr-1002

It seems to pass muster as far as I can see-- apps are finally updated properly, including calendar and contacts. Anyone see anything broken?

@markmcb
Copy link

markmcb commented Sep 27, 2019

Looks good to me. No issues with calendar or contacts.

@pachulo
Copy link
Member

pachulo commented Sep 27, 2019

Did the refresh from 16.0.4snap1rc1 and everything is working OK!
Now even the Bookmarks app works again (it stopped working with the last update).

@the-sane
Copy link

The only issue I've had with v16 in general is the missing toolbar in the new text app under dark mode, as mentioned in #902 (comment), caused by our old friend "ResourceLocator cannot find a web root": nextcloud/server#13556

@kyrofa
Copy link
Member Author

kyrofa commented Sep 27, 2019

@the-sane thanks for the heads up. As that app is only supported on v16 I don't consider it a regression, and thus it should not hold this up, do you agree?

I think this is ready for merge, but I'll wait until @the-sane confirms everything is okay.

@the-sane
Copy link

@kyrofa I agree, it shouldn’t hold anything up right now. I don’t believe that app is the default text editor yet, but it seems that’s the eventual plan so I wanted to make sure it’s on the radar.

@kyrofa
Copy link
Member Author

kyrofa commented Sep 27, 2019

@kyrofa I agree, it shouldn’t hold anything up right now.

Alright, shipping then.

@kyrofa kyrofa merged commit 66a82d8 into nextcloud-snap:develop Sep 27, 2019
@kyrofa kyrofa deleted the dependency/972/nextcloud_16 branch September 27, 2019 15:37
@emansije
Copy link

This morning I was happy to find that my NC had upgraded to version 16.0.5snap1 (16232) (I'm using the stable channel) but then I found out that the contacts app stopped working. 😞
The log shows this message:

ResourceLocator can not find a web root (root: /var/snap/nextcloud/16232/nextcloud/extra-apps/contacts, file: index.php/css/contacts/1e49-afb2-contacts.css?v=d41d8cd98f00b204e9800998ecf8427e, webRoot: , throw: true)

@kyrofa
Copy link
Member Author

kyrofa commented Sep 29, 2019

@emansije my contacts app is working fine-- can you please log an issue with what exactly is happening?

@emansije
Copy link

Sure. It's #1130

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet