New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Nextcloud to 27.1.5 #2631
Conversation
The tests do fail at the same point then the daily tests. But only for NC27+. Not sure yet what the cause is. But this line sounds interesting:
Or it fails at this point:
But this topic is out of my scope/know-how. |
We may need @kyrofa to help on this one. Not sure either. |
I suspect that the manual installation in these newer versions require write-access to the htdocs directory because it wants to write an htaccess file. The current version doesn't do that. We need to look into that, see if there's a way to opt out of that behavior. Sorry guys, that has been failing in the dailies for a while: those are intended to catch this kind of breakage flowing downstream before they bite us, but I haven't had time to investigate them, so now it's biting us. I suppose I'm the only one that receives notifications of those failures, huh. I should figure out a way to change that. |
I opened an issue on the server repo. Let's see if we get a feedback for this. nextcloud/server#42286 To be honest, I didn't find the commit that added that behavior. That are just too many commits there. :/ |
I did see it yesterday when I was looking for why the |
Wonder if we are hitting this commit. This is new in 28 and 27.1.5 [stable27] do not write htaccess file if disk space is too low by @backportbot-nextcloud in nextcloud/server#41608 |
@kyrofa Can you say anything regarding the available disk space for the tests on GitHub? Each nc release has a slightly increased size, maybe we just reached the disk limit? The commit @stondino00 linked might be new but only throws if the free disk space is lower then 10kb (or MB? not sure). |
Actually no, I think @stondino00 is spot on: the snap is a squashfs image, it's literally by definition 100% full. The available disk space on the host doesn't really matter here. |
Hey folks, do you think it makes sense to push 27.1.4 to the stable channel in the meantime? |
Yes, I just haven't verified it yet, have you? |
I've just tested a fresh install and everything seems fine. |
An upgrade also works fine, tested on my prod. |
fresh install tests completed and documented here running tests again for confirmation... logs look fine |
OK, in here they say that the latest updates solve some security issues, and they also now disclosed 2 moderate security issues that were solved in 27.1.4: So, how should we proceed @kyrofa ? |
27.1.4 is in stable, now. Regarding 27.1.5, our only real option is to wait for a fix. We can't ship stuff that doesn't pass CI, and the manual-install feature is one that I know is used by people. |
Closing as we need to wait for 27.1.6 at least. |
Fixes #2630