Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use cmake snap to build MySQL 8.0.37 #2735

Merged
merged 1 commit into from
May 9, 2024

Conversation

stondino00
Copy link
Contributor

Fixes #2734

@stondino00
Copy link
Contributor Author

@kyrofa let me know if you think I did this right pulling in the cmake snap or if it's still using the default cmake from core18. Something like this might get us by until a rebase of a newer snap core. Thanks sir.

@stondino00 stondino00 changed the title Use cmake snap to build mysql Use cmake snap to build MySQL 8.0.37 May 8, 2024
Copy link
Member

@Pilzinsel64 Pilzinsel64 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thinks that absolutely fine for now, so we can continue pushing updates. We can partly revert this after we did the core20 update.

@pachulo
Copy link
Member

pachulo commented May 8, 2024

Great stuff @stondino00 ! One request though, could you clean the commit history? Thanks!

@stondino00
Copy link
Contributor Author

Great stuff @stondino00 ! One request though, could you clean the commit history? Thanks!

How do I do this via the web on github? I don't like to use the github desktop or cli and do all the patching commits through the web. I'm not much of a programmer. I can close these and make a new clean PR if that would be easier. Thanks

@Pilzinsel64
Copy link
Member

Pilzinsel64 commented May 9, 2024

@stondino00 I don't know another way as CLI. I cleaned it for you. Still not a nice commit message, but for this you would really need to do it once again without the MySql update and just rebase the MySql-PR after this PR has been merged. I'm fine with this, but I let it to you if you want to merge it or remake a new PR.

@Pilzinsel64 Pilzinsel64 force-pushed the stondino00-cmake-snap-for-mysql branch from bd1fecc to 98e0172 Compare May 9, 2024 06:47
@Pilzinsel64 Pilzinsel64 enabled auto-merge May 9, 2024 06:48
@Pilzinsel64 Pilzinsel64 disabled auto-merge May 9, 2024 06:49
@stondino00 stondino00 merged commit 9be79e5 into develop May 9, 2024
7 checks passed
@stondino00 stondino00 deleted the stondino00-cmake-snap-for-mysql branch May 9, 2024 16:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants