-
-
Notifications
You must be signed in to change notification settings - Fork 214
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
nextcloud: update to 16.0.0 #973
Conversation
Only issue I've discovered so far (which I discovered in RC2) is not a blocking bug: nextcloud/server#15236 . |
4c01456
to
7f018c6
Compare
Hmm... something is too old on the Trusty runners used by CircleCI for these tests to pass (they pass locally on Bionic). I suspect it's just webkit-related. Trying to figure that out, probably will need to move to a modern JS interpreter. |
Is there a reason not to specify bionic in |
I'd love to, but the docs lead me to believe such a thing is impossible with the |
Thanks for the reply. It's irritating that they still rely on 14.04 as the default. Apparently you can also use
Might be worth a try. |
Wait, how did I miss that?! Thanks @omyno, I'll give that a shot now. |
Ah, it seems these tests don't pass in Xenial either. Also, the Xenial image on CircleCI is busted. I'll continue trying to move to chrome headless. |
f45e233
to
e16cb2b
Compare
Alright, got things sorted by moving the tests to chrome. |
8a27bc0
to
0e0bb0e
Compare
I have extracted the test changes from this PR into #977 so it can land before this, which will unblock the failing daily tests against upstream Nextcloud's master and allow us to setup daily tests against v16 as well. |
Resolve nextcloud-snap#972 Signed-off-by: Kyle Fazzari <kyrofa@ubuntu.com>
0e0bb0e
to
ab21c70
Compare
This PR resolves #972 by updating Nextcloud to the latest v16 release.
Note that this PR gets the groundwork of upgrading out of the way and gives us something to test, but we'll continue our tradition of not upgrading everyone until the first point release (16.0.1). Please use the
16/candidate
channel if you want to upgrade to 16.0.0 now.