Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nextcloud: update to 16.0.0 #973

Closed

Conversation

kyrofa
Copy link
Member

@kyrofa kyrofa commented Apr 25, 2019

This PR resolves #972 by updating Nextcloud to the latest v16 release.


Note that this PR gets the groundwork of upgrading out of the way and gives us something to test, but we'll continue our tradition of not upgrading everyone until the first point release (16.0.1). Please use the 16/candidate channel if you want to upgrade to 16.0.0 now.

@kyrofa
Copy link
Member Author

kyrofa commented Apr 25, 2019

Only issue I've discovered so far (which I discovered in RC2) is not a blocking bug: nextcloud/server#15236 .

@kyrofa kyrofa force-pushed the dependency/972/nextcloud_16 branch 2 times, most recently from 4c01456 to 7f018c6 Compare April 25, 2019 20:42
@kyrofa
Copy link
Member Author

kyrofa commented Apr 26, 2019

Hmm... something is too old on the Trusty runners used by CircleCI for these tests to pass (they pass locally on Bionic). I suspect it's just webkit-related. Trying to figure that out, probably will need to move to a modern JS interpreter.

@omyno
Copy link

omyno commented Apr 26, 2019

Hmm... something is too old on the Trusty runners used by CircleCI for these tests to pass (they pass locally on Bionic).

Is there a reason not to specify bionic in .circleci/config.yml?

@kyrofa
Copy link
Member Author

kyrofa commented Apr 26, 2019

Is there a reason not to specify bionic in .circleci/config.yml?

I'd love to, but the docs lead me to believe such a thing is impossible with the machine executor. I've asked the question, though.

@omyno
Copy link

omyno commented Apr 27, 2019

Thanks for the reply. It's irritating that they still rely on 14.04 as the default. Apparently you can also use image: ubuntu-1604:201903-01, which in turn uses

Ubuntu 16.04, docker 18.09.3, docker-compose 1.23.1

Might be worth a try.

@kyrofa
Copy link
Member Author

kyrofa commented Apr 27, 2019

Wait, how did I miss that?! Thanks @omyno, I'll give that a shot now.

@kyrofa
Copy link
Member Author

kyrofa commented Apr 27, 2019

Ah, it seems these tests don't pass in Xenial either. Also, the Xenial image on CircleCI is busted. I'll continue trying to move to chrome headless.

@kyrofa kyrofa force-pushed the dependency/972/nextcloud_16 branch 2 times, most recently from f45e233 to e16cb2b Compare April 28, 2019 14:41
@kyrofa
Copy link
Member Author

kyrofa commented Apr 28, 2019

Alright, got things sorted by moving the tests to chrome.

@kyrofa kyrofa force-pushed the dependency/972/nextcloud_16 branch 2 times, most recently from 8a27bc0 to 0e0bb0e Compare April 29, 2019 16:14
@kyrofa
Copy link
Member Author

kyrofa commented Apr 29, 2019

I have extracted the test changes from this PR into #977 so it can land before this, which will unblock the failing daily tests against upstream Nextcloud's master and allow us to setup daily tests against v16 as well.

Resolve nextcloud-snap#972

Signed-off-by: Kyle Fazzari <kyrofa@ubuntu.com>
@kyrofa kyrofa force-pushed the dependency/972/nextcloud_16 branch from 0e0bb0e to ab21c70 Compare May 3, 2019 16:05
@kyrofa kyrofa closed this May 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants