Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump symfony/event-dispatcher to 5.4 #997

Closed
wants to merge 1 commit into from

Conversation

vitormattos
Copy link
Contributor

I god error when I run occ upgrade after I did pull on server to get newest source from master branch. I have one app with symfony/event-dispatcher on composer.lock using newest version of this package and I identified a problem of argument typing because the method GenericEvent->getArgument() on version >= 5 of symfony/event-dispatcher have typed argument forcing to string and the GenericEventWrapper->getArgument() haven't typed argument.

Suggested steps to solve the problem:

  • bump the package symfony/event-dispatcher on 3rdparty
  • bump the 3rdparty submodule on server
  • Fix all unit tests on server after bump 3rdparty submodule
  • Implement typed argument on GenericEventWrapper on server
  • Change the places on server that request GenericEventWrapper->getArgument and cast the argument from int to string

What I did on this PR?

composer require -W symfony/console symfony/event-dispatcher-contracts symfony/event-dispatcher

Signed-off-by: Vitor Mattos <vitor@php.rio>
@vitormattos
Copy link
Contributor Author

I did rebase with CI fix and I think that I haven't permission to force push:

To github.com:nextcloud/3rdparty.git
 ! [rejected]          bump-symfony_event-dispatcher -> bump-symfony_event-dispatcher (stale info)
error: failed to push some refs to 'github.com:nextcloud/3rdparty.git'

@ChristophWurst
Copy link
Member

is it ok to mix symfony 4 and symfony 5 components?

@vitormattos
Copy link
Contributor Author

vitormattos commented Feb 15, 2022

I only bumped the symfony/event-dispatcher and related packages to him.

I can try to check the impact on server as a part of this review and report here but I think first I will need force push to fix the CI here.

@blizzz blizzz added this to the Nextcloud 25 milestone Apr 21, 2022
@come-nc come-nc removed their request for review May 5, 2022 14:50
@skjnldsv skjnldsv modified the milestones: Nextcloud 25, Nextcloud 26 Aug 19, 2022
@kesselb kesselb added the main label Oct 26, 2022
@vitormattos
Copy link
Contributor Author

outdated.

@ChristophWurst ChristophWurst deleted the bump-symfony_event-dispatcher branch December 21, 2022 15:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants