Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drop Symfony event dispatcher #1285

Merged
merged 8 commits into from Aug 28, 2023
Merged

Drop Symfony event dispatcher #1285

merged 8 commits into from Aug 28, 2023

Conversation

artonge
Copy link
Collaborator

@artonge artonge commented Aug 18, 2023 •
edited

Fix #1280

@artonge artonge force-pushed the artonge/dept/drop_symfony_event_dispatcher branch 2 times, most recently from b2f52f6 to 5d63edc Compare August 18, 2023 12:00
@artonge artonge self-assigned this Aug 18, 2023
@artonge artonge added this to the Nextcloud 28 milestone Aug 18, 2023
nickvergessen
nickvergessen approved these changes Aug 18, 2023
View reviewed changes
Copy link
Member

@nickvergessen nickvergessen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good apart from the readonly

miaulalala
miaulalala approved these changes Aug 24, 2023
View reviewed changes
Copy link
Collaborator

@miaulalala miaulalala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

Tested, works.

@artonge artonge force-pushed the artonge/dept/drop_symfony_event_dispatcher branch from c5048f0 to c31209b Compare August 28, 2023 07:57
@artonge
Copy link
Collaborator Author

artonge commented Aug 28, 2023

Ah, forgot to pull before pushing 🙈

@artonge artonge force-pushed the artonge/dept/drop_symfony_event_dispatcher branch 4 times, most recently from 6314f6a to 90fbad1 Compare August 28, 2023 09:52
@nickvergessen
Copy link
Member

So, force merge because cypress is fixed in the other PR?

artonge and others added 8 commits August 28, 2023 14:03
@artonge
Drop Symfony event dispatcher
ab75252 
Signed-off-by: Louis Chemineau <louis@chmn.me>
@artonge
Run cs:fix
28eccc3 
Signed-off-by: Louis Chemineau <louis@chmn.me>
@nickvergessen @artonge
Fix(test): Fix test
ea35c9b 
Signed-off-by: Joas Schilling <coding@schilljs.com>
@nickvergessen @artonge
fix(CI): Colorful CI output
6058e47 
Signed-off-by: Joas Schilling <coding@schilljs.com>
@nickvergessen @artonge
Fix(CS): FIx PHP 8.0 compatibility
f1fb815 
Signed-off-by: Joas Schilling <coding@schilljs.com>
@artonge
Add template params in ShareEventListener
8fd748a 
Signed-off-by: Louis Chemineau <louis@chmn.me>
@artonge
Tidy up dependencies
26f4782 
+ Bump nc/ocp
+ Remove symfony/event-dispatcher
+ Use phar for psalm

Signed-off-by: Louis Chemineau <louis@chmn.me>
@artonge
Fix return type for Capabilities
0faa2ac 
Signed-off-by: Louis Chemineau <louis@chmn.me>
@artonge
Copy link
Collaborator Author

artonge commented Aug 28, 2023

Or rebase :)

@artonge artonge force-pushed the artonge/dept/drop_symfony_event_dispatcher branch from 02b27ed to 0faa2ac Compare August 28, 2023 12:04
@artonge artonge enabled auto-merge August 28, 2023 12:12
@artonge artonge merged commit b39412b into master Aug 28, 2023
30 checks passed
@artonge artonge deleted the artonge/dept/drop_symfony_event_dispatcher branch August 28, 2023 12:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nickvergessen nickvergessen nickvergessen approved these changes

@miaulalala miaulalala miaulalala approved these changes

Assignees

@artonge artonge

Labels
3. to review bug php technical debt
Projects
None yet
Milestone
Nextcloud 28
Development

Successfully merging this pull request may close these issues.

Could not boot activity: Call to undefined method OC\\Server::getEventDispatcher()
3 participants
@artonge @nickvergessen @miaulalala