Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove aria-hidden for table header #1378

Merged
merged 1 commit into from Oct 25, 2023
Merged

Remove aria-hidden for table header #1378

merged 1 commit into from Oct 25, 2023

Conversation

JuliaKirschenheuter
Copy link
Contributor

Remove aria-hidden="true" from "Mail" and "Push"

Resolves nextcloud/server#40707

No visual changes.

@JuliaKirschenheuter JuliaKirschenheuter self-assigned this Oct 23, 2023
@JuliaKirschenheuter JuliaKirschenheuter force-pushed the fix/40707-rework_table_on_notifications_page branch 2 times, most recently from 23f584c to b800883 Compare October 25, 2023 08:42
@JuliaKirschenheuter
Copy link
Contributor Author

/compile amend /

@JuliaKirschenheuter @nextcloud-command
Remove aria-hidden for table header
bbf1a99 
Signed-off-by: julia.kirschenheuter <julia.kirschenheuter@nextcloud.com>
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
@nextcloud-command nextcloud-command force-pushed the fix/40707-rework_table_on_notifications_page branch from b800883 to bbf1a99 Compare October 25, 2023 08:47
@JuliaKirschenheuter
Copy link
Contributor Author

Static analysis / Nextcloud (pull_request) is unrelated

@JuliaKirschenheuter
Copy link
Contributor Author

failed Cypress is unrelated

@nickvergessen nickvergessen merged commit fea53ba into master Oct 25, 2023
21 of 24 checks passed
@nickvergessen nickvergessen deleted the fix/40707-rework_table_on_notifications_page branch October 25, 2023 09:09
@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 7, 2023

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the reviewing process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR reviewing process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@artonge artonge artonge approved these changes

@Pytal Pytal Pytal approved these changes

@ShGKme ShGKme ShGKme approved these changes

@szaimen szaimen Awaiting requested review from szaimen

Assignees

@JuliaKirschenheuter JuliaKirschenheuter

Labels
3. to review feedback-requested
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BITV]: rework table on notifications page
5 participants
@JuliaKirschenheuter @artonge @Pytal @ShGKme @nickvergessen