Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(sidebar): Add frontend API that allows to register custom entries #1416

Merged
merged 7 commits into from Nov 15, 2023
Merged

feat(sidebar): Add frontend API that allows to register custom entries #1416

merged 7 commits into from Nov 15, 2023

Conversation

susnux
Copy link
Contributor

@susnux susnux commented Nov 15, 2023 •
edited

This adds a front end API that allows to register plugins on the Activity tab:

  1. Register custom actions, this actions will be shown on top of the activity bar (e.g. a comments input)
  2. Register custom stream elements, meaning custom entries in the activity stream (e.g. comments)
  3. Register custom filter function for shown activities to filter out some

Why showing custom elements instead of the activity? Activities will be cleaned up while e.g. comments do not. So this allows e.g. comments to be shown within the activity sidebar tab.

@susnux susnux force-pushed the feat/frontend-api-for-activity-stream branch from bd207f5 to 490d8c8 Compare November 15, 2023 10:37
@susnux
Copy link
Contributor Author

susnux commented Nov 15, 2023

The diff looks awful but in reality e.g. Activity.vue was just renamed to GenericActivity.vue and Activity.vue is now a wrapper...

@susnux susnux force-pushed the feat/frontend-api-for-activity-stream branch from 490d8c8 to 4912c3a Compare November 15, 2023 10:51
@susnux
feat(sidebar): Add API to register custom actions to activity tab
119f6e4 
This is intended for the comments app to register the "write comment" action.

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
@susnux
feat(comments): Show user avatar instead of app icon
988afc0 
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
@susnux
feat(sidebar): Allow to register filters and custom entries
8420d2f 
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
@susnux
fix(tests): Reduce warnings while testing
7119243 
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
@susnux susnux force-pushed the feat/frontend-api-for-activity-stream branch from 4912c3a to 3f752e3 Compare November 15, 2023 11:06
@susnux
Copy link
Contributor Author

susnux commented Nov 15, 2023

/compile amend/

@susnux susnux mentioned this pull request Nov 15, 2023
Merged
4 tasks
@susnux
Copy link
Contributor Author

susnux commented Nov 15, 2023

A screen cast of how it looks when comments use it can be found here:
nextcloud/server#41491

@susnux
chore: Add missing license headers and split types from implementation
cb8f57f 
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
@susnux
chore: compile assets
0ab1a4f 
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
@susnux susnux force-pushed the feat/frontend-api-for-activity-stream branch from 3f752e3 to 0ab1a4f Compare November 15, 2023 12:40
This was referenced Nov 15, 2023
Closed
Closed
@susnux
Copy link
Contributor Author

susnux commented Nov 15, 2023

/compile amend/

@nextcloud-command
chore(assets): Recompile assets
68ed595 
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
@susnux susnux merged commit 3109bf7 into master Nov 15, 2023
47 checks passed
@susnux susnux deleted the feat/frontend-api-for-activity-stream branch November 15, 2023 13:19
@blizzz blizzz mentioned this pull request Nov 16, 2023
Merged
@github-actions GitHub Actions
Copy link

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AndyScherzinger AndyScherzinger AndyScherzinger approved these changes

@artonge artonge artonge approved these changes

@juliushaertl juliushaertl Awaiting requested review from juliushaertl

@miaulalala miaulalala Awaiting requested review from miaulalala

Assignees
No one assigned
Labels
3. to review enhancement feature: sidebar feedback-requested
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Improvements for Comments in Activity
4 participants
@susnux @AndyScherzinger @artonge @nextcloud-command