Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[stable28] fix/1481 focused links are truncated on 400% zoom #1485

Conversation

JuliaKirschenheuter
Copy link
Contributor

Manual backport of #1482

@JuliaKirschenheuter
Copy link
Contributor Author

/compile amend /

@nextcloud-command nextcloud-command force-pushed the stable28-fix/1481-focused_links_are_truncated_on_400%_zoom branch from 805d2ac to 3181c95 Compare January 2, 2024 09:50
Signed-off-by: julia.kirschenheuter <julia.kirschenheuter@nextcloud.com>

(cherry picked from commit b276113)
Signed-off-by: julia.kirschenheuter <julia.kirschenheuter@nextcloud.com>
@JuliaKirschenheuter JuliaKirschenheuter force-pushed the stable28-fix/1481-focused_links_are_truncated_on_400%_zoom branch from 3181c95 to d5bbc36 Compare January 2, 2024 16:30
Copy link

cypress bot commented Jan 2, 2024

2 flaky tests on run #1071 ↗︎

0 10 0 0 Flakiness 2

Details:

[stable28] fix/1481 focused links are truncated on 400% zoom
Project: Activity Commit: f26f687382
Status: Passed Duration: 02:46 💡
Started: Jan 2, 2024 4:36 PM Ended: Jan 2, 2024 4:39 PM
Flakiness  sidebar.cy.ts • 1 flaky test • Run E2E

View Output

Test Artifacts
Check activity listing in the sidebar > Has favorite activity Test Replay Screenshots
Flakiness  settings.cy.ts • 1 flaky test • Run E2E

View Output

Test Artifacts
Check that user's settings survive a reload > Form survive a reload Test Replay Screenshots

Review all test suite changes for PR #1485 ↗︎

@JuliaKirschenheuter JuliaKirschenheuter merged commit 006a2f5 into stable28 Jan 2, 2024
43 checks passed
@JuliaKirschenheuter JuliaKirschenheuter deleted the stable28-fix/1481-focused_links_are_truncated_on_400%_zoom branch January 2, 2024 18:20
Copy link

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants