[stable28] fix(CI): Correctly test against stable28 again #1565
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
nickvergessen
commented
Feb 15, 2024
nickvergessen
commented
- Fix regression from chore: update workflows from templates #1477
- Required for [stable28] MailQueueHandler: Catch provider errors #1559
nickvergessen
force-pushed
the
bugfix/noid/fix-ci
branch
from
ce8592b
to
a4aaab7
Compare
artonge
approved these changes
Feb 15, 2024
nickvergessen
force-pushed
the
bugfix/noid/fix-ci
branch
2 times, most recently
from
6e51fa2
to
f92e9c3
Compare
1 flaky test on run #1282 ↗︎
Details:
Review all test suite changes for PR #1565 ↗︎ |
||||||||||||||||||||
|
Cypress still failing |
|
But now it's the test itself that is failing so a code or test-code error and no longer the cypress image fails to get deployed. |
skjnldsv
approved these changes
Feb 22, 2024
|
CI will get fixed by #1580 |
skjnldsv
approved these changes
Feb 28, 2024
Signed-off-by: Joas Schilling <coding@schilljs.com>
Signed-off-by: Joas Schilling <coding@schilljs.com>
Signed-off-by: Joas Schilling <coding@schilljs.com>
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
skjnldsv
force-pushed
the
bugfix/noid/fix-ci
branch
from
ab6df60
to
40b448b
Compare
Adapte to server changes Signed-off-by: Louis Chemineau <louis@chmn.me>
|
Cherry-picked #1581 into this branch as both are needed for CI to pass. |
skjnldsv
approved these changes
Feb 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.