Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Calendar event proper formatting #420

Merged
merged 1 commit into from
Apr 21, 2020

Conversation

tcitworld
Copy link
Member

@tcitworld tcitworld commented Jan 21, 2020

See nextcloud/server#19039 first

Without this, links to calendar events are not properly formatted (the last last item has got a link on "test").
I don't know much the Activity app so there's probably an easier way to do this.

Before After
Screenshot_2020-01-21 Activity - Nextcloud Screenshot_2020-01-21 Activity - Nextcloud- 2

@nickvergessen
Copy link
Member

I can't seem to find any difference?

@tcitworld
Copy link
Member Author

tcitworld commented Jan 22, 2020

See the last line in my screenshots.

The default behavior when there's a link doesn't put a <strong> tag on the element.

@rullzer
Copy link
Member

rullzer commented Apr 16, 2020

@nickvergessen yay or nay?

@nickvergessen
Copy link
Member

sure

Signed-off-by: Thomas Citharel <tcit@tcit.fr>
@tcitworld
Copy link
Member Author

Rebased

@tcitworld tcitworld added this to In progress in Thomas things to do via automation Apr 17, 2020
Thomas things to do automation moved this from In progress to Reviewer approved Apr 21, 2020
@nickvergessen nickvergessen merged commit 1557c5b into master Apr 21, 2020
Thomas things to do automation moved this from Reviewer approved to Done Apr 21, 2020
@delete-merged-branch delete-merged-branch bot deleted the add-calendar-event-support branch April 21, 2020 09:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

None yet

3 participants