Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Port settings to vue #861

Merged
merged 1 commit into from
Aug 19, 2022
Merged

Port settings to vue #861

merged 1 commit into from
Aug 19, 2022

Conversation

CarlSchwan
Copy link
Member

@CarlSchwan CarlSchwan commented Aug 1, 2022

image

TODOs:

  • Implement saving
  • Admin settings
  • Check with the screen reader to confirm that the accessibility improved
  • Remove old php templates
  • Make cypress tests work

@CarlSchwan CarlSchwan added this to the Nextcloud 25 milestone Aug 1, 2022
@CarlSchwan CarlSchwan self-assigned this Aug 1, 2022
@CarlSchwan CarlSchwan marked this pull request as draft August 1, 2022 14:02
@CarlSchwan
Copy link
Member Author

@szaimen pointed out to me #589, I'll try to merge both efforts

@CarlSchwan CarlSchwan requested a review from artonge August 1, 2022 18:20
@CarlSchwan CarlSchwan changed the title WIP: Port settings to vue Port settings to vue Aug 1, 2022
@CarlSchwan CarlSchwan marked this pull request as ready for review August 1, 2022 21:53
Copy link
Member

@jancborchardt jancborchardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Only details:

  • Can you move the Mail/Push checkbox columns to the left again, so there’s not so much whitespace and it’s all nicely left-aligned like before? See screenshot below
  • I can’t fully tell from the code – are the "Files", "Calendar, contacts and tasks" and "Other activities" marked up as h3?

image

@nimishavijay
Copy link
Member

Can you move the Mail/Push checkbox columns to the left again, so there’s not so much whitespace and it’s all nicely left-aligned like before? See screenshot below

I actually like it how @CarlSchwan did it, before the text alignment was a bit messy.
What do you think about keeping it like this but decreasing the space between the text and checkboxes? @jancborchardt

@CarlSchwan
Copy link
Member Author

Nice! Only details:

* Can you move the Mail/Push checkbox columns to the left again, so there’s not so much whitespace and it’s all nicely left-aligned like before? See screenshot below

My main motivation to moving the checkbox to the right was to simplify the layout for screenreader (we don't have this two level of headers) and since the content is read from the left to the right the screenreader will first read the description of the checkbox and then tell the state of the mail notification and push notification for each row.

This also solves some alignment issues with the content not at all left aligned. See screenshot

align

* I can’t fully tell from the code – are the "Files", "Calendar, contacts and tasks" and "Other activities" marked up as h3?

Done, this is now using h3

@jancborchardt
Copy link
Member

Cool, sounds good @CarlSchwan – do you mind decreasing the space between text and checkboxes a bit like @nimishavijay proposed? :)

@CarlSchwan
Copy link
Member Author

I still need one approval ;)

Signed-off-by: Carl Schwan <carl@carlschwan.eu>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants