Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix translation ignore #888

Merged
merged 1 commit into from
Aug 24, 2022
Merged

Fix translation ignore #888

merged 1 commit into from
Aug 24, 2022

Conversation

nickvergessen
Copy link
Member

Ref #880 (comment)

Current error:

Those files are ignored:
Array
(
[0] => js/activity-*
[1] => js/templates.js
)
/app/js/activity-adminSettings.js:2: warning: Empty msgid. It is reserved by GNU gettext:
gettext("") returns the header entry with
meta information, not the empty string.

Tested locally and it works now.

@nickvergessen
Fix translation ignore
4192b76 
Signed-off-by: Joas Schilling <coding@schilljs.com>
@nickvergessen nickvergessen added this to the Nextcloud 25 milestone Aug 24, 2022
rakekniven
rakekniven approved these changes Aug 24, 2022
View reviewed changes
Copy link
Member

@rakekniven rakekniven left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to document this behaviour.

@nickvergessen nickvergessen marked this pull request as ready for review August 24, 2022 07:13
@nickvergessen nickvergessen merged commit 9645a92 into master Aug 24, 2022
@delete-merged-branch delete-merged-branch bot deleted the bugfix/noid/fix-translation-ignore branch August 24, 2022 07:13
@nickvergessen
Copy link
Member Author

/backport to stable24

@nickvergessen
Copy link
Member Author

/backport to stable23

@nickvergessen
Copy link
Member Author

/backport to stable22

@backportbot-nextcloud backportbot-nextcloud bot mentioned this pull request Aug 24, 2022
Merged
This was referenced Aug 24, 2022
Merged
Merged
@nickvergessen nickvergessen mentioned this pull request Aug 24, 2022
Open
2 tasks
@blizzz blizzz mentioned this pull request Aug 24, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rakekniven rakekniven rakekniven approved these changes

@tobiasKaminsky tobiasKaminsky tobiasKaminsky approved these changes

Assignees
No one assigned
Labels
3. to review bug
Projects
None yet
Milestone
Nextcloud 25
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@nickvergessen @rakekniven @tobiasKaminsky